Our slice show which works in previous releases, is throwing this error after we have migrated to 8.x-2.2:

The website encountered an unexpected error. Please try again later.
Error: Call to a member function buildUri() on null in Drupal\slick_views\Plugin\views\style\SlickViewsBase->buildElements() (line 181 of modules/contrib/slick_views/src/Plugin/views/style/SlickViewsBase.php).

it seems that thumbnail's rendered #image_style is set to empty and hence escape the isset check.

CommentFileSizeAuthor
#5 slick_views-empty-thumbnail-style-3114885-5.patch1.09 KBtheterencechan
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

theterencechan created an issue. See original summary.

gausarts’s picture

gausarts CreditAttribution: gausarts commented
Status: Active » Postponed (maintainer needs more info)

You are right. Thank you!

We should add a check for empty thumbnail image style.

Temporary solution is adding an image style. Will that possible at your end?

gausarts’s picture

gausarts CreditAttribution: gausarts commented

This last commit was actually improvement by checking empty image item:
https://git.drupalcode.org/project/slick_views/commit/87edb1d#36191f4194...

Apparently still needs checking the thumbnail style, too.

theterencechan’s picture

theterencechan CreditAttribution: theterencechan commented

In our case we only show the dots and don't display thumbnails. the latest commit still throws errors.

theterencechan’s picture

theterencechan CreditAttribution: theterencechan commented
FileSize
slick_views-empty-thumbnail-style-3114885-5.patch1.09 KB
gausarts’s picture

gausarts CreditAttribution: gausarts commented
Status: Postponed (maintainer needs more info) » Needs work

Thanks! We might need to respect both scenarios, with or without image style. Not rely on one and negate another.

At older version neglecting image style.

gausarts’s picture

gausarts CreditAttribution: gausarts commented
Status: Needs work » Fixed

Committed with minor changes as described above. Also removed no-longer relevant settings since they are already moved to SlickManager.

Thank you for contribution!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.