This is a follow-up of #2939166: Clicking "edit" dropdown button navigates to incorrect content.

Original issue attempted to fix the collision problem with suffixing IDs with the current timestamp. However, problem still sometimes persists with that solution.

I have a page with two views, both with entity operations links. Sometimes it happens that I get same timestamp/ID on both views and then the links stop working. I am not sure why Html::getUniqueId() isn't picking this up and adding a suffix at the end. It is really hard to debug this as it sometimes appears and sometimes not.

I propose to use cryptographically secure random string as a suffix. This should prevent collisions for good I think.

CommentFileSizeAuthor
#2 3114383_2.patch2.62 KBslashrsm
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

slashrsm created an issue. See original summary.

slashrsm’s picture

Status: Active » Needs review
FileSize
2.62 KB
slashrsm’s picture

Issue summary: View changes
slashrsm’s picture

  • markcarver committed 72d9bb5 on 8.x-4.x authored by slashrsm
    Issue #3114383 by slashrsm: Use random suffixes for dropbutton items...

  • markcarver committed 51be543 on 8.x-3.x authored by slashrsm
    Issue #3114383 by slashrsm: Use random suffixes for dropbutton items...
markhalliwell’s picture

Version: 8.x-3.x-dev » 8.x-4.x-dev
Status: Needs review » Fixed

Awesome, thanks!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.