Problem/Motivation

There are four deprecated services in core.services.yml scheduled for removal in Drupal 9.

Proposed resolution

Remove the services.

Remaining tasks

Patch, test, commit.

User interface changes

None

API changes

Deprecated services will no longer be available.

Data model changes

None

Release notes snippet

CommentFileSizeAuthor
#6 3114192-6.patch2.25 KBlongwave
#2 3114192.patch2.49 KBlongwave
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

longwave created an issue. See original summary.

longwave’s picture

longwave
he/him
Primary language English
Location UK
CreditAttribution: longwave at Full Fat Things commented
Status: Active » Needs review
Parent issue: » #2716163: [META] Remove deprecated classes, methods, procedural functions and code paths outside of deprecated modules on the Drupal 9 branch
FileSize
3114192.patch2.49 KB
daffie’s picture

daffie CreditAttribution: daffie commented
Status: Needs review » Reviewed & tested by the community

All deprecated code from core.services.yml has been removed.
All the code changes look good to me.
For me it is RTBC.

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
CreditAttribution: alexpott at Acro Commerce, Thunder commented
Status: Reviewed & tested by the community » Needs work 
+++ b/core/core.services.yml
@@ -330,14 +330,9 @@ services:
-  # @deprecated in Drupal 8.0.x and will be removed before 9.0.0. Use
-  #   config.storage.sync instead.
-  # @see https://www.drupal.org/node/2574957
-  config.storage.staging:

This was deprecated a long time ago! But unfortunately some contrib is using it. See http://grep.xnddx.ru/search?text=config.storage.staging&filename=

Given that we created the new service as an alias I think we should consider deprecating this one properly and for D10.

In order to do that I'd remove it from this patch and create another issue just for this service.

longwave’s picture

longwave
he/him
Primary language English
Location UK
CreditAttribution: longwave at Full Fat Things commented
Related issues: +#3115159: Properly deprecate config.storage.staging service

Raised #3115159: Properly deprecate config.storage.staging service

longwave’s picture

longwave
he/him
Primary language English
Location UK
CreditAttribution: longwave at Full Fat Things commented
Status: Needs work » Needs review
FileSize
3114192-6.patch2.25 KB

Status: Needs review » Needs work

The last submitted patch, 6: 3114192-6.patch, failed testing. View results

longwave’s picture

longwave
he/him
Primary language English
Location UK
CreditAttribution: longwave at Full Fat Things commented
Status: Needs work » Needs review

Unrelated fail, back to needs review.

daffie’s picture

daffie CreditAttribution: daffie commented
Status: Needs review » Reviewed & tested by the community

The deprecated service "config.storage.staging" has been removed fom the as instructed by @alexpott. There is a followup created for the properly deprecation of the service "config.storage.staging". All deprecated code from core.services.yml has been removed. All the code changes look good to me. Back to RTBC.

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
CreditAttribution: alexpott at Acro Commerce, Thunder commented
Status: Reviewed & tested by the community » Fixed

Committed 7dcbb0e and pushed to 9.0.x. Thanks!

  • alexpott committed 7dcbb0e on 9.0.x 
    Issue #3114192 by longwave, daffie, alexpott: Remove deprecated services...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.