Problem/Motivation

simpletest_uninstall() was modified in #3110862: Remove simpletest module from core but cannot be automatically tested because uninstalling Simpletest destroys the entire test environment.

It looks like there is just a missing use statement:

use Drupal\Core\Test\EnvironmentCleaner;

Proposed resolution

Add the use statement and manually test.

Remaining tasks

Patch, test, commit.

User interface changes

Simpletest can be successfully uninstalled.

API changes

None

Data model changes

None

Release notes snippet

None

CommentFileSizeAuthor
#2 3114026.patch466 byteslongwave
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

longwave created an issue. See original summary.

longwave’s picture

longwave
he/him
Primary language English
Location UK
CreditAttribution: longwave at Full Fat Things commented
Title: simpletest_uninstall does not work » simpletest_uninstall() does not work
Status: Active » Needs review
FileSize
3114026.patch466 bytes
Berdir’s picture

Berdir
Primary language German
Location Switzerland
CreditAttribution: Berdir at MD Systems GmbH commented
Status: Needs review » Reviewed & tested by the community

Manually tested, which is the only way to trigger this. Without the patch, the update fails, with the patch it completes.

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
CreditAttribution: alexpott as a volunteer and at Acro Commerce, Thunder commented
Status: Reviewed & tested by the community » Fixed

Committed 2eaeb44 and pushed to 9.0.x. Thanks!

  • alexpott committed 2eaeb44 on 9.0.x 
    Issue #3114026 by longwave: simpletest_uninstall() does not work

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.