Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
Need to remove getMessageIterator() deprecated in drupal:8.8.0 and removed from drupal:9.0.0
Comment | File | Size | Author |
---|---|---|---|
#9 | interdiff.3114017.5-9.txt | 15.37 KB | longwave |
#9 | 3114017-9.patch | 17.88 KB | longwave |
Comments
Comment #2
hash6 CreditAttribution: hash6 at QED42 for Drupal India Association commentedgetMessageIterator() is deprecated in drupal:8.8.0 and is removed from drupal:9.0.0. in
- core/modules/migrate/tests/src/Unit/MigrateNullIdMapTest.php
- core/modules/migrate/tests/src/Unit/MigrateSqlIdMapTest.php
- core/modules/migrate/src/Plugin/migrate/id_map/Sql.php
- core/modules/migrate/src/Plugin/migrate/id_map/NullIdMap.php
Comment #3
hash6 CreditAttribution: hash6 at QED42 for Drupal India Association commentedComment #4
hash6 CreditAttribution: hash6 at QED42 for Drupal India Association commentedComment #5
hash6 CreditAttribution: hash6 at QED42 for Drupal India Association commentedComment #6
longwaveFairly simple deprecation, all mentions of
getMessageIterator
are removed after this patch.Comment #7
longwaveComment #8
alexpottLet's widen this issue to cover the deprecated code paths that are still left in migrate module rather doing every code path in the module one-by-one. This is a follow-up from #3111344: Remove deprecated code from migrate module
Comment #9
longwaveFixed all remaining deprecations in the module, except one in MigrateDestinationInterface:
I guess this is also safe to refactor away now? There are many implementations that all need updating, and I haven't found where this is called but I guess if it still passes in a migration that should be removed now too.
Comment #10
BramDriesenLooks good! :-)
Comment #11
alexpott@longwave nice find on \Drupal\migrate\Plugin\MigrateDestinationInterface::fields() - can we get a follow-up for that - or look in the existing issue queue. I've not managed to find where this method is even called from yet.
Comment #12
Gábor Hojtsy+1 to RTBC, looks good other than the lack of the identified followup.
Comment #13
alexpottI've created the follow-up #3114974: \Drupal\migrate\Plugin\MigrateDestinationInterface::fields() $migration argument is deprecated.
Committed 9483ed9 and pushed to 9.0.x. Thanks!