Early Bird Registration for DrupalCon Portland 2024 is open! Register by 23:59 PST on 31 March 2024, to get $100 off your ticket.
Problem/Motivation
To remove dependency to Classy, we need to ensure core theme aren't relying on any markup in Classy. #3096349: Create test for confirming Themes do not depend on Classy templates has added test coverage to ensure that markup isn't being inherited from Classy. Currently, lots of templates have been added as ignored.
Proposed resolution
Ensure all templates have been removed from the skip lists, and copies of those templates exist in core themes.
Remaining tasks
User interface changes
API changes
Data model changes
Release notes snippet
Comment | File | Size | Author |
---|---|---|---|
#11 | 3113608-force-classy-comparison.txt | 150.07 KB | lauriii |
#10 | interdiff__6-10.txt | 2.2 KB | bnjmnm |
#10 | 3113608-10--9X.patch | 150.1 KB | bnjmnm |
#10 | 3113608-10_8X.patch | 149.92 KB | bnjmnm |
#6 | 3113608-6_9X.patch | 149.8 KB | bnjmnm |
Comments
Comment #2
lauriiiThis should be postponed until #3050389: [META] Remove dependency to Classy from core themes has been resolved.
Comment #3
lauriiiThis was actually postponed on #3096349: Create test for confirming Themes do not depend on Classy templates, not the meta issue 😜
Comment #4
bnjmnmThe patch may be 149k, but it is a gentle read. Other than the changes to
ConfirmClassyCopiesTest
, which was modified to also check for templates, the other changes are removing template names from the skip-list inThemesNotUsingClassyTemplatesTest
and making copies of template files, where some calls to attach_library are changed when it requests classy libraries. The only thing to watch out for with the template copies is for some files, git--find-copies
does not compare the copied file to the version in Classy. In those cases, the patch will show theattach_library()
call being added instead of changed.Comment #6
bnjmnmThe test failed due to it being an 8.x patch being test on 9.x. Here are individual versions for 8 and 9.
Comment #8
bnjmnmThe failure in the 9X patch is an unrelated Media Library test that is known to intermittently fail. Queueing a re-test.
Comment #9
lauriiiConfirmed that all templates have been listed here correctly 👍
attach_library
calls to reference Classy libraries lead into test failures in all themes.Nit: Any thoughts on hard coding this before the
file_get_contents()
call?Comment #10
bnjmnmGood call, that would be fine in this case since it's unlikely the skip arrays will change after this. Hard coding is simpler and less redundant.
Comment #11
lauriiiHere's the test patch I mentioned earlier on #9. This should be only used for reviewing the changes.
Changes in #10 address my earlier feedback. 👍
Comment #13
bnjmnm(note that the test failure reported in #12 was due to the 8.x patch being tested on 9. Added an 8 test.
Comment #14
alexpottCommitted 7c6f55e and pushed to 9.0.x. Thanks!
Committed f33429b and pushed to 8.9.x. Thanks!
One more step :)