Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.When contrib modules are brought via git submodules, and in the case of "entity_translation", this won't have a timestamp entry in its .info file, so the following warning will show on the status page:
Notice: Undefined index: datestamp in media_requirements() (line 142 of /app/sites/all/modules/contrib/media/media.install).
The code should check if the key is set before using it. I will attach a patch for it shortly.
| Comment | File | Size | Author |
|---|---|---|---|
| #9 | undefined_index_timestamp-3113045-9.patch | 3.14 KB | fjgarlin |
| |||
| #8 | undefined_index_timestamp-3113045-8.patch | 1.54 KB | fjgarlin |
| |||
Comments
Comment #2
fjgarlin CreditAttribution: fjgarlin as a volunteer and commentedComment #3
fjgarlin CreditAttribution: fjgarlin as a volunteer and commentedPatch attached.
Comment #4
fjgarlin CreditAttribution: fjgarlin as a volunteer and commentedComment #5
joseph.olstadlooks good, but I haven'T tested it yet.
Comment #6
GuyPaddock CreditAttribution: GuyPaddock at Inveniem commentedThis should also handle similar logic for the
file_entitymodule a few lines further up. Right now, even with this patch applied, I am still seeing this error:We're pulling file entity dev in via GIT.
Comment #7
joseph.olstadentity_translation 1.0 has been out for a long time now, and 1.1 came out recently, it's been a long time since beta6, so I think we could just remove these entity_translation checks in the hook_requirements
submit me a new patch that removes ONLY the entity_translation checks in this hook_requirements, and I'll put it in.
otherwise, feel free to doctor up the latest patch and make the warning go away.
either way works for me.
Comment #8
fjgarlin CreditAttribution: fjgarlin as a volunteer and commentedThis would be the new patch addressing #7.
For the issue also reported in #6, we cannot apply the same logic as there is no fallback value. We could regex compare on the version to see if the version is correct or allowed, but I'm not entirely sure of how the regex would look like as we want "7.x-2.0" and above but not "7.x-2.0-beta/alpha/...". I guess it'll be a fix between regex and number comparisons. As I'm not sure about how that would look like I'm just addressing #7.
Comment #9
fjgarlin CreditAttribution: fjgarlin as a volunteer and commented@GuyPaddock this is an attempt to check the (correct) version for "file_entity". It checks version and creates a made up value for the date so that it passes or fail the test under.
So it contains suggestions from #6 and #7.
@joseph.olstad #8 would only remove the "entity_translation" requirements. #9 would do that and also fix the "file_entity" warning.
Comment #10
joseph.olstadok thanks for this, looks good
Comment #14
joseph.olstadComment #15
GuyPaddock CreditAttribution: GuyPaddock at Inveniem commentedProps to @fjgarlin for addressing #6, and props to @joseph.olstad for getting this in. Thank you both!