Support from Acquia helps fund testing for Drupal Acquia logo

Comments

saschaeggi created an issue. See original summary.

saschaeggi’s picture

Tested patch with Claro & Seven.

saschaeggi’s picture

Status: Active » Needs review
sasanikolic’s picture

FileSize
115.1 KB

@saschaeggi this indeed fixes the indentation, but I noticed some strange issues with the focus on the drag handle. Even if I focus the inner paragraph, the focus element stays on the outside and it's misaligned with the (fixed) drag handle. We can fix that here or in a followup.

See the screenshot attached.

sasanikolic’s picture

Status: Needs review » Needs work
saschaeggi’s picture

Status: Needs work » Needs review
FileSize
7.17 KB
936 bytes

Good catch, updated the patch to solve this issue.
Also see image of the fix:

Thanks!

saschaeggi’s picture

Hide old patch

sasanikolic’s picture

I made some quick fixes for the formatting in order to have the code more readable and use the double colon for the before pseudo element.

Looks good to me.

saschaeggi’s picture

Assigned: saschaeggi » Unassigned
Status: Needs review » Reviewed & tested by the community

Tested, works for me, thanks for the improvements @sasanikolic.

Berdir’s picture

Status: Reviewed & tested by the community » Fixed

Thanks, committed.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.

sasanikolic’s picture

@Berdir, as we noticed some issues with the drag handles increased width in the default theme, I made some improvements in the following patch. Also did some quickfix for the alignments of the handles, as they were looking very misaligned. Let me know if I should revert that and maybe fix it in a followup together with the * sign that gets displayed when you drag an item?

Attaching also before and after screenshots.

miro_dietiker’s picture

Looks much better. I don't know how much you changed the handle, i don't see too much difference.

What i see though is that the "*" for a changed row is mispositioned in regular Seven, while it is OK in Claro.
Is this a similar regression? Maybe fix it together as it's around the same handle element?

sasanikolic’s picture

In Claro the handle and handle * sign were reimplemented with custom styles, display table and table-cell structure. Not related to this ticket, but will try to fix it in the followup. Let's discuss stuff there.