Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
Drag & drop handles are misaligned on the left
Comment | File | Size | Author |
---|---|---|---|
#13 | drag-drop-handles-3108997-13.patch | 1.17 KB | sasanikolic |
#13 | Claro after.png | 94.69 KB | sasanikolic |
#13 | Claro before.png | 96.4 KB | sasanikolic |
#13 | Seven after.png | 133.29 KB | sasanikolic |
#13 | Seven before.png | 134.14 KB | sasanikolic |
Comments
Comment #2
saschaeggiTested patch with Claro & Seven.
Comment #3
saschaeggiComment #4
sasanikolic CreditAttribution: sasanikolic at MD Systems GmbH commented@saschaeggi this indeed fixes the indentation, but I noticed some strange issues with the focus on the drag handle. Even if I focus the inner paragraph, the focus element stays on the outside and it's misaligned with the (fixed) drag handle. We can fix that here or in a followup.
See the screenshot attached.
Comment #5
sasanikolic CreditAttribution: sasanikolic at MD Systems GmbH commentedComment #6
saschaeggiGood catch, updated the patch to solve this issue.
Also see image of the fix:
Thanks!
Comment #7
saschaeggiHide old patch
Comment #8
sasanikolic CreditAttribution: sasanikolic at MD Systems GmbH commentedI made some quick fixes for the formatting in order to have the code more readable and use the double colon for the before pseudo element.
Looks good to me.
Comment #9
saschaeggiTested, works for me, thanks for the improvements @sasanikolic.
Comment #11
BerdirThanks, committed.
Comment #13
sasanikolic CreditAttribution: sasanikolic at MD Systems GmbH commented@Berdir, as we noticed some issues with the drag handles increased width in the default theme, I made some improvements in the following patch. Also did some quickfix for the alignments of the handles, as they were looking very misaligned. Let me know if I should revert that and maybe fix it in a followup together with the * sign that gets displayed when you drag an item?
Attaching also before and after screenshots.
Comment #14
miro_dietikerLooks much better. I don't know how much you changed the handle, i don't see too much difference.
What i see though is that the "*" for a changed row is mispositioned in regular Seven, while it is OK in Claro.
Is this a similar regression? Maybe fix it together as it's around the same handle element?
Comment #15
sasanikolic CreditAttribution: sasanikolic at MD Systems GmbH commentedIn Claro the handle and handle * sign were reimplemented with custom styles, display table and table-cell structure. Not related to this ticket, but will try to fix it in the followup. Let's discuss stuff there.