Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
Comment | File | Size | Author |
---|---|---|---|
#16 | interdiff-3112367-9-16.txt | 1.72 KB | Hardik_Patel_12 |
#16 | 3112367-16.patch | 7.34 KB | Hardik_Patel_12 |
Comments
Comment #2
Hardik_Patel_12 CreditAttribution: Hardik_Patel_12 at QED42 for Drupal India Association commentedKindly apply a new patch.
Comment #3
Hardik_Patel_12 CreditAttribution: Hardik_Patel_12 at QED42 for Drupal India Association commentedComment #4
swatichouhan012 CreditAttribution: swatichouhan012 at Valuebound for Valuebound commented@Hardik_Patel_12 Can you please add screenshot before and after patch, I checked without patch apply here is no issue in asset.
Comment #5
hash6 CreditAttribution: hash6 at QED42 for Drupal India Association commentedComment #6
hash6 CreditAttribution: hash6 at QED42 for Drupal India Association commentedThanks @Hardik_Patel_12, for the patch.
@swatichouhan012 FileSystemInterface before Drupal 9.x was optional and is required now
drupal-check somehow did not detect it.
Comment #7
longwaveThis whole method can be refactored away now.
Comment #8
hash6 CreditAttribution: hash6 at QED42 for Drupal India Association commentedComment #9
hash6 CreditAttribution: hash6 at QED42 for Drupal India Association commentedComment #10
longwaveThis does duplicate some work done in #3104307: Remove BC layers in various Drupal\Core components
There is a remaining @todo in AssetResolver::getCssAssets() - not sure how or when this was deprecated:
Comment #11
prabha1997 CreditAttribution: prabha1997 at Valuebound for Valuebound commentedI am working on this issue
Comment #12
prabha1997 CreditAttribution: prabha1997 at Valuebound for Valuebound commentedComment #14
longwaveI was wrong about #10 as this needs properly deprecating in #3069052: Properly deprecate the stylesheets-remove key from theme info.yml files. first, so we can't remove it yet.
Reuploading #9 and marking it RTBC.
Comment #15
alexpottThe $libraries_directory_file_finder deprecation stuff shouldn't be removed. This is an 8.9.x deprecation for Drupal 10.
Comment #16
Hardik_Patel_12 CreditAttribution: Hardik_Patel_12 at QED42 for Drupal India Association commentedKindly review a new patch.
Comment #17
Hardik_Patel_12 CreditAttribution: Hardik_Patel_12 at QED42 for Drupal India Association commentedComment #18
andypostBack to RTBC as remaining method use own issue #3069052: Properly deprecate the stylesheets-remove key from theme info.yml files.
Comment #19
andypostComment #20
alexpottCommitted 617441c and pushed to 9.0.x. Thanks!
Fixed on coding standard on commit.