Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.Problem/Motivation
Only 5 @deprecated constants remain in system.module and one deprecated test trait. There is also core/modules/system/tests/modules/deprecation_test/deprecation_test.module but that is for testing deprecation itself, so should stay intact.
Proposed resolution
Remove the 5 deprecated constants and test trait.
Remaining tasks
Do it.
User interface changes
None.
API changes
None that was not pre-announced.
Data model changes
None.
Release notes snippet
N/A.
| Comment | File | Size | Author |
|---|---|---|---|
| #14 | 3111942-14.patch | 8.72 KB | Gábor Hojtsy |
| #2 | 3111942.patch | 9.38 KB | Gábor Hojtsy |
Comments
Comment #2
Gábor HojtsyComment #3
Gábor HojtsyNot just the module file, clarify title.
Comment #4
BerdirThe reason we didn't remove that trait yet is because that is afaik still used by simpletest.module, and at least some of the constants are still used yet.
Comment #5
Gábor HojtsyThanks! Looking forward to see what fails :)
Comment #6
longwaveThe constants can't go until the two related issues are done.
Comment #8
Gábor HojtsyI think its good to have the chain documented as issues. So let's postpone then. To me it sounds awkward that we are introducing a new API that we are using to deprecate to even though we were supposed to do that up to 8.8.0, but apparently there are core committers on #3015812: Introduce new Theme extension object and properly deprecate REGIONS_VISIBLE and REGIONS_ALL to consider that.
Comment #9
Gábor Hojtsy1. #3015812: Introduce new Theme extension object and properly deprecate REGIONS_VISIBLE and REGIONS_ALL was moved to Drupal 9.1 and #3112263: Undeprecate REGIONS_* constants was opened instead. So that covers the two region constants.
2. Re DRUPAL_USER_TIMEZONE_* #3015811: Properly deprecate DRUPAL_USER_TIMEZONE_* constants does indeed seem to take care of them based on my grepping. At least to properly deprecate them, then we still need to remove them.
3. Re AssertPageCacheContextsAndTagsTrait, that is tricky. There seem to be 42 uses in core:
It is not only used by simpletest module, only one use is removed in #3110862: Remove simpletest module from core.
Comment #10
BerdirThere are two AssertPageCacheContextsAndTagsTrait traits in core, only one of them is deprecated, you need to grep for the namespace.
Comment #11
Gábor HojtsyIndeed.
Comment #12
Berdir3. simpletest.module is gone, looks like we missed to remove that trait so we can now do it here. that said, we might want to check if the simpletest contrib module has already duplicated that trait or embedded it and if not, create an issue there to update it?
Comment #13
Gábor Hojtsy@Berdir: I would expect that would be in https://git.drupalcode.org/project/simpletest/tree/8.x-3.x/src but I cannot find it there. So opened #3114594: Copy AssertPageCacheContextsAndTagsTrait.php to simpletest module.
Comment #14
Gábor HojtsyOk there was agreement in #3015811: Properly deprecate DRUPAL_USER_TIMEZONE_* constants so that landed too, means we can remove those constants.
#3112263: Undeprecate REGIONS_* constants dealt with the region constants and those should not be removed now.
#3114594: Copy AssertPageCacheContextsAndTagsTrait.php to simpletest module was opened to add the trait to the simpletest module.
Comment #15
longwaveGood to go if tests pass!
Comment #16
alexpottCommitted 78db412 and pushed to 9.0.x. Thanks!