I came across the issue that if you enter a field description and disable opacity input, the description appears twice in the field widget.

Also, I think wrapping the widget in a fieldset is not neccesary (and not beneficial) without opacity, it would only include a single field.

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

kmetz created an issue. See original summary.

kmetz’s picture

Issue summary: View changes
kmetz’s picture

bartlangelaan’s picture

Status: Active » Needs review

Status: Needs review » Needs work

The last submitted patch, 3: double-field-description-3111039-3.patch, failed testing. View results

balintk’s picture

I ran into the same issue. Thank you for the patch, @kmetz. Here is my slightly adjusted version which still renders the container element around the field so that JavaScript logic that expects that markup (i.e. Drupal.behaviors.color_field_spectrum) doesn't break.

lonalore’s picture

Status: Needs work » Reviewed & tested by the community

Patch from #6 works perfectly. Thank you!

DuneBL’s picture

I confirm tha #6 is perfect!
Thank you

NickDickinsonWilde’s picture

Status: Reviewed & tested by the community » Fixed

Thanks for the patch and testing, committed.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.

rwam’s picture

FileSize
17.73 KB
11.62 KB

Sorry, but this patch breaks the spectrum widget.

EXPECTED BEHAVIOR using $element['#type'] = 'fieldset';

correct display

CURRENT BEHAVIOR using $element['#type'] = 'container';

wrong display

@NickDickinsonWilde - can this issue be reopened or should I create a new ticket?