Problem/Motivation

The new match_limit setting that was added to the entity reference autocomplete widget settings form for Drupal 8.8 (see the related issue for the history, if anyone's interested), currently does not work for dynamic entity reference fields.

Proposed resolution

Add the match_limit setting to the dynamic entity reference widget's render array (similar to the core EntityReferenceAutocompleteWidget class).

CommentFileSizeAuthor
#8 3110807-8.patch6.68 KBjibran
#8 interdiff-31e128.txt5.65 KBjibran
#2 dynamic_entity_reference-append-match-operation-settings-3110807-2.patch1.59 KBChewi3
dynamic_entity_reference_match_limit.png69.96 KBChewi3
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

ThomasJacobs created an issue. See original summary.

Chewi3’s picture

Chewi3 CreditAttribution: Chewi3 at iO commented
Status: Active » Needs review
FileSize
dynamic_entity_reference-append-match-operation-settings-3110807-2.patch1.59 KB

I created a patch that fixes this issue.

Status: Needs review » Needs work

The last submitted patch, 2: dynamic_entity_reference-append-match-operation-settings-3110807-2.patch, failed testing. View results

Chewi3’s picture

Chewi3 CreditAttribution: Chewi3 at iO commented
Assigned: Unassigned » Chewi3
Chewi3’s picture

Chewi3 CreditAttribution: Chewi3 at iO commented
Assigned: Chewi3 » Unassigned
jibran’s picture

jibran
he/him
Primary language Urdu
Location Sydney, Australia
CreditAttribution: jibran as a volunteer commented
Issue tags: +Needs tests, +Needs upgrade path, +Needs upgrade path tests

Thanks, for the patch. Fix makes sense let's add test for this and also we are updating the default config here we need an upgrade path and upgrade path tests here something like text_post_update_add_required_summary_flag_form_display.

ReeceMarsland’s picture

ReeceMarsland CreditAttribution: ReeceMarsland at Zoocha commented

Patch works for me. Thanks

jibran’s picture

jibran
he/him
Primary language Urdu
Location Sydney, Australia
CreditAttribution: jibran as a volunteer commented
Status: Needs work » Needs review
Issue tags: -Needs tests, -Needs upgrade path, -Needs upgrade path tests
FileSize
interdiff-31e128.txt5.65 KB
3110807-8.patch6.68 KB

Given that this setting is added in #2863188: Hardcoded result size limit in the entity reference autocomplete widget. with upgrade path and test so we don't need those here as config already have these values. I have confirmed that on an existing site.
This will fix the test fails which means we already have tests for this functionality.

  • jibran committed 5a4ec5b on 8.x-1.x 
    Issue #3110807 by ThomasJacobs, jibran: Autocomplete match_limit setting...

  • jibran committed dcbec0f on 8.x-2.x 
    Issue #3110807 by ThomasJacobs, jibran: Autocomplete match_limit setting...
jibran’s picture

jibran
he/him
Primary language Urdu
Location Sydney, Australia
CreditAttribution: jibran as a volunteer commented
Status: Needs review » Fixed

Thanks all! Committed and pushed to 1.x and 2.x.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.