Make more explicit the email address is necessary to recover the password

Submitting a patch for the issue with the changes as mentioned.

Not sure how the Media_library test fail is relevant here. Patch looks straightforward. Retest requested.

I actually checked it online before submitting the patch.
Still I'll follow the suggestion you mentioned and update the patch.

Apologies for the mistake in the patch name.
Submitting the same updated patch with the correct name.

As a string change, this is a minor-only issue. Since 8.9.x and 9.0.x are now in beta, I'm moving this to 9.1.x. Thanks!

+++ b/core/modules/user/src/AccountForm.php
@@ -96,7 +96,7 @@ public function form(array $form, FormStateInterface $form_state) {
-      '#description' => $this->t('A valid email address. All emails from the system will be sent to this address. The email address is not made public and will only be used if you wish to receive a new password or wish to receive certain news or notifications by email.'),
+      '#description' => $this->t('A valid email address. All emails from the system will be sent to this address. The email address is not made public and will only be used if you need to be contacted about your account, for example when you forget your password, or you wish to receive certain news or notifications by email.'),

The old phrase "...wish to receive a new password..." makes better sense than new "...when you forget your password..."

Maybe we are undoing something that was purposely introduced?

+ '#description' => $this->t('A valid email address. All emails from the system will be sent to this address. The email address is not made public and will only be used if you need to be contacted about your account, for example when you forget your password, or you wish to receive certain news or notifications by email.'),

I checked the statement seems good semantically and as already mentioned by @kiamlaluno, need is making much more sense that to wish.

+1 For RTBC.

I will apply patch and review this issue

@kiamlaluno New message- "A valid email address. All emails from the system will be sent to this address. The email address is not made public and will only be used if you need to be contacted about your account, for example when you forget your password, or you wish to receive certain news or notifications by email." is more appropriate. Screenshots are attached with and without patch. +1 for RTBC

applied #14 patch applied successfully
thanks for the patch
For ref sharing screenshot....

patch #14 applied successfully
LGTM moving to RTBC

Removing credit for redundant screenshots with no additional information.

Setting to "needs work" because this is making an already long description even longer. The element it is in does not have a max width so it will make it even more difficult to read. It would be preferable to communicate the same concepts with a shorter string such as:
This address is not made public. It will only be used for password resets and (if opted-in) notifications.

Making the current description more accurate by extending it's length will dilute its usefulness as the length will reduce the likelihood it is read or correctly interpreted.

I changed the message according to what @bnjmnm said. I agree that the longer this description gets, the more likely it is to misinterpret it. This new suggestion is shorter and just as clear as the others.

Here's a patch based on what @apaderno said in #33.

patch #36 successfully applied.
The message on the user screen was successfully changed, follow the evidence image, moving to rtbc

Starting a review.

The issue summary is out of date and does not reflect the change being made. Tagging for an Issue Srummary update. This is suitable for a novice. See Write an issue summary for an existing issue for guidance.

This is suggesting a change to user interface text and tagged Usability. So that still needs to happen but having the IS updated will make that easier.

I will try to work on this issue.

I did the changes suggested in the summary of the issue and changed the approach for easier review.

Hi!

I applied the patch in #36 and did the changes based on what @apaderno said in #51.

Please, review this.

Hi, i will be doing the review

Everything looked fine for me, all the new user form with the message passed in #51

This has not proved to be a quick fix :(

I discussed this issue with @Gábor Hojtsy, a drupal product manager. We agreed that the new text is better than the old text and therefore that we should make this change. It is more concise and accurate.

Re issue credit: I've removed credit for screenshots. They are not that useful here - we can read the text in the code. Reviews should consider the usability and correctness of the text. I've tried to credit everyone who had a material affect on the final text.

Committed and pushed 2258208083 to 10.1.x and ec6f344d7c to 10.0.x and 073dd1f255 to 9.5.x. Thanks!