I found the below issue while check through drupal-check tool.
drupal-check -ad web/modules/contrib/admin_toolbar
11/11 [▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓] 100%
------ -----------------------------------------------------------------------------------------------------------------------
Line admin_toolbar_tools/src/Plugin/Derivative/ExtraLinks.php
------ -----------------------------------------------------------------------------------------------------------------------
55 Constructor of class Drupal\admin_toolbar_tools\Plugin\Derivative\ExtraLinks has an unused parameter $base_plugin_id.
------ -----------------------------------------------------------------------------------------------------------------------
[ERROR] Found 1 error
Comment | File | Size | Author |
---|---|---|---|
#2 | admin_toolbar-unused-parameter-3109978-#2-8.x-2.0.png | 19.65 KB | vsujeetkumar |
#2 | admin_toolbar-unused-parameter-3109978-#2-8.x-2.0.patch | 1.13 KB | vsujeetkumar |
|
Comments
Comment #2
vsujeetkumar CreditAttribution: vsujeetkumar at Srijan | A Material+ Company for Drupal India Association commentedAdding a patch that will remove the unused variable error for admin_toolbar_tools module.
Comment #3
vsujeetkumar CreditAttribution: vsujeetkumar at Srijan | A Material+ Company for Drupal India Association commentedComment #4
vsujeetkumar CreditAttribution: vsujeetkumar at Srijan | A Material+ Company for Drupal India Association commentedComment #5
idebr CreditAttribution: idebr at iO commentedInstead of an unused variable, we now have an unused class property.
How about we remove the variable from the ::create() return value instead?
Comment #6
idebr CreditAttribution: idebr at iO commentedComment #8
adriancidThanks for the issue.