We just released Shipping 2.0-beta8, the last shipping beta.
With that release out of the way, we proceeded with two necessary backwards compatibility breaks, in preparation for RC1:
#3096883: [Backwards Compatibility break] Rework and expand ShippingRate
#3106301: [Backwards Compatibility break] Inject the workflow manager into ShippingMethodBase
All shipping method plugins need to be updated for the two changes, and the module's composer.json file should be updated to require commerce_shipping "^2.0-rc1", once the RC1 release is out.
| Comment | File | Size | Author |
|---|---|---|---|
| #5 | 3109828-5.patch | 14.71 KB | mglaman |
| #4 | 3109828-4.patch | 14.71 KB | mglaman |
| #2 | 3109828-2-fix-bc-breaks.patch | 4.76 KB | bojanz |
Comments
Comment #2
bojanz commentedHere is an initial patch.
Unfortunately it doesn't work as-is, because the ShippingRate object now expects to receive the shipping method entity ID ($this->parentEntity->id()), which is not available in the request services that USPS uses. I was unsure how to pass that along from the plugin, the existing architecture confuses me a bit, so I'm leaving that to the maintainer.
Comment #3
mglamanComment #4
mglamanHere's a working patch. \Drupal\commerce_usps\USPSRateRequestInterface::getRates now required the shipping method entity and that gets the ID passed down to the rate.
Comment #5
mglamanRC1 is released
Comment #6
rhovlandTested on latest commerce 2.x-dev and commerce_shipping 2.x-dev and it works as expected.
Comment #7
mglamanThanks for testing, @rhovland! Committed.