Review of the 8.x-1.x branch (commit 324e0ee):
Your README.md does not follow best practices (headings need to be uppercase). See https://www.drupal.org/node/2181737 .
The INTRODUCTION section is missing.
The REQUIREMENTS section is missing.
The INSTALLATION section is missing.
The CONFIGURATION section is missing.
FILE: ...000000/site1101/web/vendor/drupal/pareviewsh/pareview_temp/README.md
--------------------------------------------------------------------------
FOUND 0 ERRORS AND 33 WARNINGS AFFECTING 33 LINES
--------------------------------------------------------------------------
6 | WARNING | Line exceeds 80 characters; contains 209 characters
12 | WARNING | Line exceeds 80 characters; contains 123 characters
14 | WARNING | Line exceeds 80 characters; contains 87 characters
15 | WARNING | Line exceeds 80 characters; contains 86 characters
16 | WARNING | Line exceeds 80 characters; contains 88 characters
22 | WARNING | Line exceeds 80 characters; contains 101 characters
23 | WARNING | Line exceeds 80 characters; contains 98 characters
29 | WARNING | Line exceeds 80 characters; contains 84 characters
31 | WARNING | Line exceeds 80 characters; contains 93 characters
38 | WARNING | Line exceeds 80 characters; contains 82 characters
51 | WARNING | Line exceeds 80 characters; contains 107 characters
53 | WARNING | Line exceeds 80 characters; contains 85 characters
61 | WARNING | Line exceeds 80 characters; contains 185 characters
63 | WARNING | Line exceeds 80 characters; contains 125 characters
66 | WARNING | Line exceeds 80 characters; contains 115 characters
68 | WARNING | Line exceeds 80 characters; contains 162 characters
98 | WARNING | Line exceeds 80 characters; contains 112 characters
99 | WARNING | Line exceeds 80 characters; contains 113 characters
102 | WARNING | Line exceeds 80 characters; contains 146 characters
104 | WARNING | Line exceeds 80 characters; contains 94 characters
109 | WARNING | Line exceeds 80 characters; contains 113 characters
115 | WARNING | Line exceeds 80 characters; contains 117 characters
116 | WARNING | Line exceeds 80 characters; contains 142 characters
117 | WARNING | Line exceeds 80 characters; contains 242 characters
119 | WARNING | Line exceeds 80 characters; contains 96 characters
128 | WARNING | Line exceeds 80 characters; contains 93 characters
144 | WARNING | Line exceeds 80 characters; contains 108 characters
145 | WARNING | Line exceeds 80 characters; contains 102 characters
167 | WARNING | Line exceeds 80 characters; contains 88 characters
170 | WARNING | Line exceeds 80 characters; contains 91 characters
178 | WARNING | Line exceeds 80 characters; contains 141 characters
185 | WARNING | Line exceeds 80 characters; contains 170 characters
191 | WARNING | Line exceeds 80 characters; contains 105 characters
Comment | File | Size | Author |
---|---|---|---|
#3 | 3109709-3.patch | 9.51 KB | Ankush_03 |
Comments
Comment #2
Ankush_03Comment #3
Ankush_03Adding patch !
Comment #4
Ankush_03Ignoring phpcs line length issue in case of urls.
Comment #6
lussolucaCommitted and pushed to 2.x branch
Thanks!