Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
core_version_requirement: ^8 || ^9 needs to be added to info.yml.
Comment | File | Size | Author |
---|---|---|---|
#9 | 3109707-9-interdiff.txt | 695 bytes | kim.pepper |
#9 | 3109707-9.patch | 1.14 KB | kim.pepper |
#6 | 3109707-6.patch | 1.29 KB | KapilV |
#5 | 3109707-5-interdiff.txt | 441 bytes | kim.pepper |
#5 | 3109707-5.patch | 1.34 KB | kim.pepper |
Comments
Comment #2
Ankush_03Adding patch !
Comment #3
Ankush_03Comment #4
kim.pepperI ran drupal-check on this module and found an issue:
Comment #5
kim.pepperNeed to update composer.json too.
Comment #6
KapilV CreditAttribution: KapilV as a volunteer and at OpenSense Labs commentedComment #7
agoradesign CreditAttribution: agoradesign commentedIn #3032946: Update dependency monolog/monolog to version 2.x there's currently the discussion, if switching to monolog library 2.x should be done on a new 2.x branch (mainly because this move would also mean dropping PHP 5.x support).
I'd propose the following approach, if a 2.x branch will be opened anyway: do not commit this in 1.x branch, as this isn't meant for D9 anyway. And in a 2.x branch, we should raise requirements even higher to 8.8.3 and start a semantic versioning branch instead. Here's an example of a module, where I have already started a new branch for semantic versioning (and you need a new branch for this step anyway): https://www.drupal.org/project/commerce_order_autovalidate
Comment #8
eiriksmI vote we get this in, so people can start upgrading their sites?
If we have to wait for a 2.x branch and development to start, there is no way we can upgrade any of our sites to drupal 9. A simple fix as the first fix seems like a good start.
Tested on Drupal 9, works like a charm
Comment #9
kim.pepperThis is a tweak to composer.json. We don't need to specify a core version there.
Comment #11
lussolucaCommitted and pushed to 2.x branch
Thanks!
Comment #12
dpi@lussoluca this issue was originally for 1.x branch, could we also have this applied there. Thanks!
Comment #13
dpiIf 1.x will not be supported for D9 lets communicate it on the project page.
Comment #14
lussolucaYes, we'll only support 2.x on Drupal 9. I've updated the project page