Problem/Motivation

Packages were held back because of the older version of PHP should now be upgradable since we use PHP 7.3.

Proposed resolution

Upgrade all the packages we can.

Remaining tasks

Test all the things.

User interface changes

None.

API changes

None (hopefully).

Data model changes

None.

Release notes snippet

$ composer-lock-diff --no-links
+------------------------------+---------+----------+
| Production Changes           | From    | To       |
+------------------------------+---------+----------+
| asm89/stack-cors             | 1.2.0   | 1.3.0    |
| composer/semver              | 1.5.0   | 1.5.1    |
| egulias/email-validator      | 2.1.11  | 2.1.15   |
| pear/console_getopt          | v1.4.2  | v1.4.3   |
| pear/pear-core-minimal       | v1.10.9 | v1.10.10 |
| pear/pear_exception          | v1.0.0  | v1.0.1   |
| psr/log                      | 1.1.0   | 1.1.2    |
| symfony-cmf/routing          | 2.1.0   | 2.1.1    |
| symfony/class-loader         | v3.4.36 | v3.4.37  |
| symfony/console              | v4.4.2  | v4.4.3   |
| symfony/debug                | v4.4.2  | v4.4.3   |
| symfony/dependency-injection | v4.4.2  | v4.4.3   |
| symfony/error-handler        | v4.4.2  | v4.4.3   |
| symfony/event-dispatcher     | v4.4.2  | v4.4.3   |
| symfony/http-foundation      | v4.4.2  | v4.4.3   |
| symfony/http-kernel          | v4.4.2  | v4.4.3   |
| symfony/mime                 | v5.0.2  | v5.0.3   |
| symfony/process              | v4.4.2  | v4.4.3   |
| symfony/routing              | v4.4.2  | v4.4.3   |
| symfony/serializer           | v4.4.2  | v4.4.3   |
| symfony/translation          | v4.4.2  | v4.4.3   |
| symfony/validator            | v4.4.2  | v4.4.3   |
| symfony/var-dumper           | v5.0.2  | v5.0.3   |
| symfony/yaml                 | v4.4.2  | v4.4.3   |
| twig/twig                    | v2.12.1 | v2.12.3  |
| typo3/phar-stream-wrapper    | v3.1.3  | v3.1.4   |
+------------------------------+---------+----------+

+---------------------------+--------+--------+
| Dev Changes               | From   | To     |
+---------------------------+--------+--------+
| composer/ca-bundle        | 1.2.4  | 1.2.6  |
| composer/composer         | 1.9.1  | 1.9.2  |
| composer/xdebug-handler   | 1.3.3  | 1.4.0  |
| fabpot/goutte             | v3.2.3 | v3.3.0 |
| instaclick/php-webdriver  | 1.4.6  | 1.4.7  |
| justinrainbow/json-schema | 5.2.8  | 5.2.9  |
| seld/jsonlint             | 1.7.1  | 1.7.2  |
| seld/phar-utils           | 1.0.1  | 1.0.2  |
| squizlabs/php_codesniffer | 3.5.0  | 3.5.3  |
| symfony/browser-kit       | v4.4.2 | v4.4.3 |
| symfony/css-selector      | v4.4.2 | v4.4.3 |
| symfony/dom-crawler       | v4.4.2 | v4.4.3 |
| symfony/filesystem        | v4.4.2 | v4.4.3 |
| symfony/finder            | v4.4.2 | v4.4.3 |
| symfony/lock              | v4.4.2 | v4.4.3 |
| symfony/phpunit-bridge    | v4.4.2 | v4.4.3 |
+---------------------------+--------+--------+
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Gábor Hojtsy created an issue. See original summary.

longwave’s picture

DamienMcKenna’s picture

Tagging as a requirement for Drupal 9.0-beta1.

DamienMcKenna’s picture

DamienMcKenna’s picture

Tagging as a requirement for Drupal 9.0-beta1.

longwave’s picture

Status: Active » Needs review
FileSize
95.56 KB

Let's see if a full composer update passes tests.

$ composer-lock-diff --no-links
+------------------------------+---------+----------+
| Production Changes           | From    | To       |
+------------------------------+---------+----------+
| asm89/stack-cors             | 1.2.0   | 1.3.0    |
| composer/semver              | 1.5.0   | 1.5.1    |
| egulias/email-validator      | 2.1.11  | 2.1.15   |
| pear/console_getopt          | v1.4.2  | v1.4.3   |
| pear/pear-core-minimal       | v1.10.9 | v1.10.10 |
| pear/pear_exception          | v1.0.0  | v1.0.1   |
| psr/log                      | 1.1.0   | 1.1.2    |
| symfony-cmf/routing          | 2.1.0   | 2.1.1    |
| symfony/class-loader         | v3.4.36 | v3.4.37  |
| symfony/console              | v4.4.2  | v4.4.3   |
| symfony/debug                | v4.4.2  | v4.4.3   |
| symfony/dependency-injection | v4.4.2  | v4.4.3   |
| symfony/error-handler        | v4.4.2  | v4.4.3   |
| symfony/event-dispatcher     | v4.4.2  | v4.4.3   |
| symfony/http-foundation      | v4.4.2  | v4.4.3   |
| symfony/http-kernel          | v4.4.2  | v4.4.3   |
| symfony/mime                 | v5.0.2  | v5.0.3   |
| symfony/process              | v4.4.2  | v4.4.3   |
| symfony/routing              | v4.4.2  | v4.4.3   |
| symfony/serializer           | v4.4.2  | v4.4.3   |
| symfony/translation          | v4.4.2  | v4.4.3   |
| symfony/validator            | v4.4.2  | v4.4.3   |
| symfony/var-dumper           | v5.0.2  | v5.0.3   |
| symfony/yaml                 | v4.4.2  | v4.4.3   |
| twig/twig                    | v2.12.1 | v2.12.3  |
+------------------------------+---------+----------+

+-----------------------------------+--------+---------+
| Dev Changes                       | From   | To      |
+-----------------------------------+--------+---------+
| composer/ca-bundle                | 1.2.4  | 1.2.6   |
| composer/composer                 | 1.9.1  | 1.9.2   |
| composer/xdebug-handler           | 1.3.3  | 1.4.0   |
| fabpot/goutte                     | v3.2.3 | v3.3.0  |
| instaclick/php-webdriver          | 1.4.6  | 1.4.7   |
| justinrainbow/json-schema         | 5.2.8  | 5.2.9   |
| myclabs/deep-copy                 | 1.7.0  | 1.9.5   |
| phar-io/manifest                  | 1.0.1  | 1.0.3   |
| phar-io/version                   | 1.0.1  | 2.0.1   |
| phpdocumentor/reflection-common   | 1.0.1  | 2.0.0   |
| phpdocumentor/reflection-docblock | 4.3.2  | 4.3.4   |
| phpdocumentor/type-resolver       | 0.5.1  | 1.0.1   |
| phpspec/prophecy                  | 1.9.0  | v1.10.2 |
| phpunit/php-code-coverage         | 5.3.2  | 6.1.4   |
| phpunit/php-file-iterator         | 1.4.5  | 2.0.2   |
| phpunit/php-timer                 | 1.0.9  | 2.1.2   |
| phpunit/php-token-stream          | 2.0.2  | 3.1.1   |
| phpunit/phpunit                   | 6.5.14 | 7.5.20  |
| phpunit/phpunit-mock-objects      | 5.0.10 | REMOVED |
| sebastian/comparator              | 2.1.3  | 3.0.2   |
| sebastian/diff                    | 2.0.1  | 3.0.2   |
| sebastian/environment             | 3.1.0  | 4.2.3   |
| sebastian/resource-operations     | 1.0.0  | 2.0.1   |
| seld/jsonlint                     | 1.7.1  | 1.7.2   |
| seld/phar-utils                   | 1.0.1  | 1.0.2   |
| squizlabs/php_codesniffer         | 3.5.0  | 3.5.3   |
| symfony/browser-kit               | v4.4.2 | v4.4.3  |
| symfony/css-selector              | v4.4.2 | v4.4.3  |
| symfony/dom-crawler               | v4.4.2 | v4.4.3  |
| symfony/filesystem                | v4.4.2 | v4.4.3  |
| symfony/finder                    | v4.4.2 | v4.4.3  |
| symfony/lock                      | v4.4.2 | v4.4.3  |
| symfony/phpunit-bridge            | v4.4.2 | v4.4.3  |
| webmozart/assert                  | 1.5.0  | 1.6.0   |
+-----------------------------------+--------+---------+
bradjones1’s picture

While we're at it is it within scope to be more explicit about the PHP version max requirement as well as minimum? This reminds me of #3103255: Add upper PHP constraint to composer.json and/or the installer and #3098281: Ensure that 'composer update' evaluates dependencies using the correct PHP version which would be a straightforward way to make this kind of upgrade path even easier to perform in the future?

The latter of those tickets is RTBC and the former is a one-line change.

longwave’s picture

Gábor Hojtsy’s picture

Can we isolate this from #3106918: Drop support of PHPUnit 6 in Drupal 9 because it will never get used anyway so they don't overlap (ie. remove the dependency updates that are there) or should we postpone this?

Gábor Hojtsy’s picture

Status: Needs review » Needs work
Issue tags: +Needs reroll
longwave’s picture

Status: Needs work » Needs review
Issue tags: -Needs reroll
FileSize
61.34 KB
$ composer-lock-diff --no-links
+------------------------------+---------+----------+
| Production Changes           | From    | To       |
+------------------------------+---------+----------+
| asm89/stack-cors             | 1.2.0   | 1.3.0    |
| composer/semver              | 1.5.0   | 1.5.1    |
| egulias/email-validator      | 2.1.11  | 2.1.15   |
| pear/console_getopt          | v1.4.2  | v1.4.3   |
| pear/pear-core-minimal       | v1.10.9 | v1.10.10 |
| pear/pear_exception          | v1.0.0  | v1.0.1   |
| psr/log                      | 1.1.0   | 1.1.2    |
| symfony-cmf/routing          | 2.1.0   | 2.1.1    |
| symfony/class-loader         | v3.4.36 | v3.4.37  |
| symfony/console              | v4.4.2  | v4.4.3   |
| symfony/debug                | v4.4.2  | v4.4.3   |
| symfony/dependency-injection | v4.4.2  | v4.4.3   |
| symfony/error-handler        | v4.4.2  | v4.4.3   |
| symfony/event-dispatcher     | v4.4.2  | v4.4.3   |
| symfony/http-foundation      | v4.4.2  | v4.4.3   |
| symfony/http-kernel          | v4.4.2  | v4.4.3   |
| symfony/mime                 | v5.0.2  | v5.0.3   |
| symfony/process              | v4.4.2  | v4.4.3   |
| symfony/routing              | v4.4.2  | v4.4.3   |
| symfony/serializer           | v4.4.2  | v4.4.3   |
| symfony/translation          | v4.4.2  | v4.4.3   |
| symfony/validator            | v4.4.2  | v4.4.3   |
| symfony/var-dumper           | v5.0.2  | v5.0.3   |
| symfony/yaml                 | v4.4.2  | v4.4.3   |
| twig/twig                    | v2.12.1 | v2.12.3  |
| typo3/phar-stream-wrapper    | v3.1.3  | v3.1.4   |
+------------------------------+---------+----------+

+---------------------------+--------+--------+
| Dev Changes               | From   | To     |
+---------------------------+--------+--------+
| composer/ca-bundle        | 1.2.4  | 1.2.6  |
| composer/composer         | 1.9.1  | 1.9.2  |
| composer/xdebug-handler   | 1.3.3  | 1.4.0  |
| fabpot/goutte             | v3.2.3 | v3.3.0 |
| instaclick/php-webdriver  | 1.4.6  | 1.4.7  |
| justinrainbow/json-schema | 5.2.8  | 5.2.9  |
| seld/jsonlint             | 1.7.1  | 1.7.2  |
| seld/phar-utils           | 1.0.1  | 1.0.2  |
| squizlabs/php_codesniffer | 3.5.0  | 3.5.3  |
| symfony/browser-kit       | v4.4.2 | v4.4.3 |
| symfony/css-selector      | v4.4.2 | v4.4.3 |
| symfony/dom-crawler       | v4.4.2 | v4.4.3 |
| symfony/filesystem        | v4.4.2 | v4.4.3 |
| symfony/finder            | v4.4.2 | v4.4.3 |
| symfony/lock              | v4.4.2 | v4.4.3 |
| symfony/phpunit-bridge    | v4.4.2 | v4.4.3 |
+---------------------------+--------+--------+
Gábor Hojtsy’s picture

Status: Needs review » Reviewed & tested by the community

There looks like only 3 updates that are minor updates, all others are patch updates and no major version updates.

The minor updates are asm89/stack-cors, composer/xdebug-handler and fabpot/goutte.

Only stack-cors is a non-dev depdency. Their changes are very limited between 1.2.0 and 1.3.0: https://github.com/asm89/stack-cors/compare/1.2.0...1.3.0 -- the only real change is this fix for Chrome's CORB: https://github.com/asm89/stack-cors/commit/426300e8d2d645693cd001077c8f6...

So all in this looks very innocent to me :)

In other words what we turned up is regular dependency updates and not due to PHP 7.3 being allowed now. That was phpunit, but already dealt with :)

longwave’s picture

To confirm this a bit further after applying this patch composer outdated shows the only things we are missing are Symfony 5, PHPUnit 8 and some more commits on behat/mink-selenium2-driver. None of those commits are useful to us: https://github.com/minkphp/MinkSelenium2Driver/compare/0a09c43..e2f7a8a

$ composer outdated --direct
behat/mink-selenium2-driver  1.3.x-dev 0a09c43 dev-master e2f7a8a
drupal/core                  9.0.x-dev         9.0.x-dev 8642e3d
drupal/core-project-message  9.0.x-dev         9.0.x-dev 30f8699
drupal/core-vendor-hardening 9.0.x-dev         9.0.x-dev b214dea
phpunit/phpunit              7.5.20            8.5.2
symfony/browser-kit          v4.4.3            v5.0.3
symfony/css-selector         v4.4.3            v5.0.3
symfony/dom-crawler          v4.4.3            v5.0.3
symfony/filesystem           v4.4.3            v5.0.3
symfony/finder               v4.4.3            v5.0.3
symfony/lock                 v4.4.3            v5.0.3
symfony/phpunit-bridge       v4.4.3            v5.0.3
alexpott’s picture

Status: Reviewed & tested by the community » Fixed

Committed 01793fb and pushed to 9.0.x. Thanks!

  • alexpott committed 01793fb on 9.0.x
    Issue #3109261 by longwave, Gábor Hojtsy: Update composer dependencies...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.

xjm’s picture

Issue summary: View changes

Pasting the full list in the release notes in lieu of writing a custom release note for alpha2.