Problem/Motivation

Now that Symfony sessions are in place and available from $request->getSession()</span>, core should be updated that it uses that instead of accessing <code>$_SESSION directly.

This issue is was extracted from #2473875: Convert uses of $_SESSION to symfony session retrieved from the request to improve reviewability.

Proposed resolution

Remaining tasks

User interface changes

None

API changes

None

CommentFileSizeAuthor
#4 3109042-5.diff14.63 KBznerol
#4 interdiff-5.txt7.57 KBznerol
#2 3109042-2.diff7.06 KBznerol
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

znerol created an issue. See original summary.

znerol’s picture

znerol CreditAttribution: znerol commented
Status: Active » Needs review
FileSize
3109042-2.diff7.06 KB

Status: Needs review » Needs work

The last submitted patch, 2: 3109042-2.diff, failed testing. View results

znerol’s picture

znerol CreditAttribution: znerol commented
Status: Needs work » Needs review
FileSize
interdiff-5.txt7.57 KB
3109042-5.diff14.63 KB

Some hunks transferred from patch in #2473875: Convert uses of $_SESSION to symfony session retrieved from the request.

andypost’s picture

andypost
he/him
Primary language Russian
CreditAttribution: andypost as a volunteer and at Skilld commented
Status: Needs review » Reviewed & tested by the community

Looks it covers all related places

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
CreditAttribution: alexpott at Acro Commerce, Thunder commented
Status: Reviewed & tested by the community » Fixed

Committed and pushed 5b023333eb to 9.0.x and d251008c0d to 8.9.x. Thanks!

  • alexpott committed 5b02333 on 9.0.x 
    Issue #3109042 by znerol: Convert uses of $_SESSION in update module and...

  • alexpott committed d251008 on 8.9.x 
    Issue #3109042 by znerol: Convert uses of $_SESSION in update module and...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.