Remove deprecated node.module action plugins and leftovers

Try searching for @trigger_error() and @deprecated in the whole module, there's quite a bit more to remove. And then also "group legacy" for any tests that are covering the things we are removing.

Updating the parent issue. we don't want to remove the whole module :)

we don't want to remove the whole module :)

😆

1. Just like @JeroenT, I cannot find what other removals @Berdir is referring to…

2. +++ b/core/modules/node/src/NodeAccessControlHandlerInterface.php
   @@ -28,27 +28,6 @@ interface NodeAccessControlHandlerInterface {
   -  public function writeGrants(NodeInterface $node, $delete = TRUE);
   

   We also still need to remove the implementation of this, at \Drupal\node\NodeAccessControlHandler::writeGrants().

Really tempted to mark this RTBC, but let's wait for DrupalCI to confirm tests are still passing, and let's wait for @Berdir to respond with what other things he spotted that should be removed.

Thanks for opening this issue, the clear issue summary and the patch, @JeroenT! 🙏

Sorry about that, I probably looked at the wrong branch, we already did node module in #3097428: Remove node.module BC layers

Committed 5fca5fe and pushed to 9.0.x. Thanks!

+++ b/core/modules/node/src/NodeAccessControlHandler.php
@@ -156,14 +156,6 @@ public function acquireGrants(NodeInterface $node) {
-  /**
-   * {@inheritdoc}
-   */
-  public function writeGrants(NodeInterface $node, $delete = TRUE) {
-    $grants = $this->acquireGrants($node);
-    $this->grantStorage->write($node, $grants, NULL, $delete);
-  }

+++ b/core/modules/node/src/NodeAccessControlHandlerInterface.php
@@ -28,27 +28,6 @@ interface NodeAccessControlHandlerInterface {
-   * @deprecated in drupal:8.0.0 and is removed from drupal:9.0.0.
-   *   Use \Drupal\node\NodeAccessControlHandlerInterface::acquireGrants().
-   */
-  public function writeGrants(NodeInterface $node, $delete = TRUE);

So this was deprecated before our deprecation policy was defined. So there's no @trigger_error() BUT it has been deprecated for the nearly entirety of the Drupal 8 cycle and is completely untested and any contrib or custom implementations of the interface will not be broken by the removal so I think this okay.

I'm running into WSODs for drupal core views that relied on these, and I'm not the only one.
See #3045570: Plugin missing for node actions

How are/were these views supposed to get updated?
The actions were deprecated, and the install config was updated, which is good for new installs.
D8 early adopters are left in the lurch.

Sorry to necropost, but before I open a new issue I thought I'd check here.

@AaronBauman Please file new issue and link it here, migrations should be in-place as the issue just removes remains

ok, new issue: #3229700: Need update path for deleted core actions