Drupal 9 Deprecated Code Report [#3108765]

Depreciated report for Node authorize link

------ ----------------------------------------------------------------------------------
Line node_authlink.module
------ ----------------------------------------------------------------------------------
137 Call to deprecated function db_select():
in drupal:8.0.0 and is removed from drupal:9.0.0. Instead, get
a database connection injected into your service from the container and
call select() on it. For example,
149 Call to deprecated function drupal_set_message():
in drupal:8.5.0 and is removed from drupal:9.0.0.
Use \Drupal\Core\Messenger\MessengerInterface::addMessage() instead.
162 Call to deprecated function db_select():
in drupal:8.0.0 and is removed from drupal:9.0.0. Instead, get
a database connection injected into your service from the container and
call select() on it. For example,
173 Call to deprecated function drupal_set_message():
in drupal:8.5.0 and is removed from drupal:9.0.0.
Use \Drupal\Core\Messenger\MessengerInterface::addMessage() instead.
194 Call to deprecated function db_query():
in drupal:8.0.0 and is removed from drupal:9.0.0. Instead,
get a database connection injected into your service from the container
and call query() on it. For example,
358 Call to deprecated method randomBytes() of class Drupal\Component\Utility\Crypt:
in drupal:8.8.0 and is removed from drupal:9.0.0.
Use PHP's built-in random_bytes() function instead.
361 Call to deprecated function db_insert():
in drupal:8.0.0 and is removed from drupal:9.0.0. Instead, get
a database connection injected into your service from the container and
call insert() on it. For example,
384 Call to deprecated function db_delete():
in drupal:8.0.0 and is removed from drupal:9.0.0. Instead, get
a database connection injected into your service from the container and
call delete() on it. For example,
393 Call to deprecated function node_type_get_types():
in drupal:8.0.0 and is removed from drupal:9.0.0.
Use \Drupal\node\Entity\NodeType::loadMultiple().
403 Call to deprecated function db_select():
in drupal:8.0.0 and is removed from drupal:9.0.0. Instead, get
a database connection injected into your service from the container and
call select() on it. For example,
412 Call to deprecated function db_delete():
in drupal:8.0.0 and is removed from drupal:9.0.0. Instead, get
a database connection injected into your service from the container and
call delete() on it. For example,
------ ----------------------------------------------------------------------------------

------ --------------------------------------------------------------------------
Line src\Form\NodeAuthlinkNodeForm.php
------ --------------------------------------------------------------------------
77 Call to deprecated method entityManager() of class Drupal:
in drupal:8.0.0 and is removed from drupal:9.0.0.
Use \Drupal::entityTypeManager() instead in most cases. If the needed
method is not on \Drupal\Core\Entity\EntityTypeManagerInterface, see the
deprecated \Drupal\Core\Entity\EntityManager to find the
correct interface or service.
204 Call to deprecated function drupal_set_message():
in drupal:8.5.0 and is removed from drupal:9.0.0.
Use \Drupal\Core\Messenger\MessengerInterface::addMessage() instead.
------ --------------------------------------------------------------------------

[ERROR] Found 13 errors

Comment	File	Size	Author
#15	node_authlink-drupal_9_upgrade_composer_patches-3108765-15-8.x.patch	6.12 KB	Eduardo Morales Alberti
#15	interdiff_14_15.txt	245 bytes	Eduardo Morales Alberti
#15	interdiff_11_15.txt	267 bytes	Eduardo Morales Alberti
#14	interdiff_11_14.txt	267 bytes	Eduardo Morales Alberti
#14	node_authlink-drupal_9_upgrade_composer_patches-3108765-14-8.x.patch	6.43 KB	Eduardo Morales Alberti
#11	interdiff_7-11.txt	212 bytes	malaynayak
#11	3108765-11.patch	6.47 KB	malaynayak
#7	interdiff_4-7.patch	390 bytes	malaynayak
#7	3108765-7.patch	6.47 KB	malaynayak
#6	interdiff_4-6.txt	6.83 KB	malaynayak
#6	3108765-6.patch	361 bytes	malaynayak
#4	3108765.patch	6.11 KB	malaynayak

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Comment #1

25 January 2020 at 10:18

kswamy created an issue. See original summary.

Comment #2

malaynayak CreditAttribution: malaynayak as a volunteer and at Acquia for Drupal India Association commented 25 January 2020 at 11:32

Assigned:

Unassigned

» malaynayak

Comment #3

selva.swamy@gmail.com CreditAttribution: selva.swamy@gmail.com as a volunteer and commented 25 January 2020 at 12:11

Assigned:

malaynayak

» selva.swamy@gmail.com

@malaynayak Am Looking into this issue

Comment #4

malaynayak CreditAttribution: malaynayak as a volunteer and at Acquia for Drupal India Association commented 25 January 2020 at 12:17

Status:

Active

» Needs review

File	Size
3108765.patch	6.11 KB

@kswamy I have created the patch. Please review.

Comment #5

malaynayak CreditAttribution: malaynayak as a volunteer and at Acquia for Drupal India Association commented 25 January 2020 at 12:18

Issue tags:

+GCWIndia2020, +punedrupalgroup

Comment #6

malaynayak CreditAttribution: malaynayak as a volunteer and at Acquia for Drupal India Association commented 25 January 2020 at 12:32

File	Size
3108765-6.patch	361 bytes
interdiff_4-6.txt	6.83 KB

Added core_version_requirement into .info.yml file.

Comment #7

malaynayak CreditAttribution: malaynayak as a volunteer and at Acquia for Drupal India Association commented 25 January 2020 at 12:36

File	Size
3108765-7.patch	6.47 KB
interdiff_4-7.patch	390 bytes

Added a wrong patch on #6. Adding the correct one with interdiff.

Comment #8

msuthars

Pune

CreditAttribution: msuthars as a volunteer and at QED42 for Drupal India Association commented 25 January 2020 at 13:02

Status:

Needs review

» Reviewed & tested by the community

@malaynayak Thanks for the patch. I applied patch and check manually & with the upgrade status module, The patch is Drupal 9 compatible.

Comment #9

pratik_kamble

Pune, India

CreditAttribution: pratik_kamble at QED42 for Drupal India Association commented 25 January 2020 at 19:17

@malaynayak

     foreach ($form_state->getValues() as $key => $value) {
-      drupal_set_message($key . ': ' . $value);
+      $this->messenger->addMessage($key . ': ' . $value);

$this->messenger->addMessage($key . ': ' . $value); should be $this->messenger()->addMessage($key . ': ' . $value);

Comment #10

pratik_kamble

Pune, India

CreditAttribution: pratik_kamble at QED42 for Drupal India Association commented 25 January 2020 at 19:17

Status:

Reviewed & tested by the community

» Needs work

Comment #11

malaynayak CreditAttribution: malaynayak as a volunteer and at Acquia for Drupal India Association commented 25 January 2020 at 19:21

Status:

Needs work

» Needs review

File	Size
3108765-11.patch	6.47 KB
interdiff_7-11.txt	212 bytes

Thanks @pratik_kamble for pointing out the issue.

Adding the modified patch, please review.

Comment #12

ravimane23 CreditAttribution: ravimane23 as a volunteer and at TATA Consultancy Services commented 2 June 2020 at 07:18

I applied #11 patch and check manually & with the upgrade status module, The patch worked for me.

Comment #13

selva.swamy@gmail.com CreditAttribution: selva.swamy@gmail.com as a volunteer and commented 2 June 2020 at 10:15

Assigned:

selva.swamy@gmail.com

» Unassigned

Comment #14

Eduardo Morales Alberti

Spanish

Spain, 🇪🇺

CreditAttribution: Eduardo Morales Alberti as a volunteer and at Metadrop commented 7 July 2020 at 09:58

Status:

Needs review

» Reviewed & tested by the community

File	Size
node_authlink-drupal_9_upgrade_composer_patches-3108765-14-8.x.patch	6.43 KB
interdiff_11_14.txt	267 bytes

Added patch removing composer compatibility because does not apply using composer patches, (this patch is only for composer patches) based on #11 patch.

Patch reviewed using upgrade status module.

Comment #15

Eduardo Morales Alberti

Spanish

Spain, 🇪🇺

CreditAttribution: Eduardo Morales Alberti as a volunteer and at Metadrop commented 7 July 2020 at 10:06

File	Size
interdiff_11_15.txt	267 bytes
interdiff_14_15.txt	245 bytes
node_authlink-drupal_9_upgrade_composer_patches-3108765-15-8.x.patch	6.12 KB

2 files were hidden/shown/deleted

File	Size
node_authlink-drupal_9_upgrade_composer_patches-3108765-14-8.x.patch	6.43 KB
interdiff_11_14.txt	267 bytes

Sorry, I uploaded the wrong patch for composer patches.

Comment #16

hudri

German

Austria

CreditAttribution: hudri commented 6 October 2020 at 09:25

Do NOT use patch #14 or #15, it contradicts the core purpose of this issue! Patch #11 is the last correct one.

If you want to install a v8 only module with composer, see this post on Drupal Answers

Comment #17

12 October 2020 at 16:04

malaynayak authored 2fc0c26 on 8.x-1.x

Issue #3108765 by malaynayak: Drupal 9 Deprecated Code Report

Comment #18

Honza Pobořil CreditAttribution: Honza Pobořil commented 12 October 2020 at 16:05

Status:

Reviewed & tested by the community

» Fixed

Thank you

Comment #19

hudri

German

Austria

CreditAttribution: hudri commented 19 October 2020 at 13:34

Hi @malaynayak and @Bobik,
could you please generate a new stable release containing the D9 patch? Even though we now can composer require the dev version in a D9 project, I still feel better when I don't have to add a dependency to dev-release in a live project.

Thank you very much.

Comment #20

Honza Pobořil CreditAttribution: Honza Pobořil commented 19 October 2020 at 13:58

Do you think it is good idea to publish release after one week of testing in dev which probably nobody use?

Comment #21

hudri

German

Austria

CreditAttribution: hudri commented 20 October 2020 at 10:23

Malaynayak's patch is already 11 month old, and there is no functional change in this patch, just 1:1 replacements like drupal_set_message to \Drupal::messenger() or db_select to \Drupal::database(). Can't see a lot of risk here.