Problem/Motivation
When you install the Umami profile, the Layout Builder and Layout Discovery modules are enabled by default. However, currently only the recipes content type is using layout builder. This means that there's some disparity on how we expect users to make changes to the page layout of recipes versus articles and basic page.
Proposed resolution
Enable layout builder by default on all content types to make it easier for users to modify the layout of these pages. This ensures that new-to-Drupal users have a good experience and see how powerful Drupal is.
Remaining tasks
User interface changes
API changes
Data model changes
Release notes snippet
Comment | File | Size | Author |
---|---|---|---|
#14 | interdiff_9-14.txt | 982 bytes | raman.b |
#14 | 3108503-14.patch | 16.09 KB | raman.b |
#7 | interdiff_5-7.txt | 373 bytes | vsujeetkumar |
#7 | 3108503_7.patch | 16.45 KB | vsujeetkumar |
#5 | interdiff-2-5.txt | 15.49 KB | kjay |
Issue fork drupal-3108503
Show commands
Start within a Git clone of the project using the version control instructions.
Or, if you do not have SSH keys set up on git.drupalcode.org:
Comments
Comment #2
kjay CreditAttribution: kjay commentedAttached is a patch that does nothing more than enable Layout Builder for the Page and Article content types in Umami. It would be great to hear thoughts on the following notes:
Comment #4
markconroy CreditAttribution: markconroy at Annertech commentedHi @kjay
This looks great, and is a great demo of the power of Drupal OOTB.
Two items that came up during our testing:
Besides those two items, great work. Thanks.
Comment #5
kjay CreditAttribution: kjay commentedThanks @markconroy for the review
You were right, enabling the 'Full content' display made the 'Allow each content item to have its layout customized.' option to become available.
Attached is a patch that takes care of the two points you have suggested but does not yet fix the tests.
Leaving as 'needs work' due to the tests to be done.
Comment #7
vsujeetkumar CreditAttribution: vsujeetkumar at Srijan | A Material+ Company for Drupal India Association commentedFixed test, Please review.
Comment #10
markconroy CreditAttribution: markconroy at Annertech commentedSetting to needs review to let the test bots do their magic.
Comment #11
markconroy CreditAttribution: markconroy at Annertech commentedAdding europe2020 tag so this can be worked on during DrupalCon
Comment #12
markconroy CreditAttribution: markconroy at Annertech commentedI'm going to mark this as RTBC.
It installs fine, has no custom code besides what Drupal config exports, and each content type is now using Layout Builder for "Full content" view mode.
Thanks for working on this @kjay @vsujeetkumar
Comment #13
quietone CreditAttribution: quietone as a volunteer commentedUnfortunately, the latest patch has a test failure and I believe it should be testing on 9.2.x. Setting NW.
Comment #14
raman.b CreditAttribution: raman.b at OpenSense Labs commentedResolving the failed test case
Comment #15
markconroy CreditAttribution: markconroy at Annertech commentedThanks for that review @quietone
Thanks for the new patch @raman.b
RTBC.
Comment #16
alexpottCommitted b4311ce and pushed to 9.2.x. Thanks!
Comment #19
effulgentsia CreditAttribution: effulgentsia at Acquia commentedI don't know if we want to highlight Umami stuff in the release highlights, but if we do, I think this is a worthy item to include. Tagging for now, just in case.