Enable layout builder by default on all content types in Umami [#3108503]

Problem/Motivation

When you install the Umami profile, the Layout Builder and Layout Discovery modules are enabled by default. However, currently only the recipes content type is using layout builder. This means that there's some disparity on how we expect users to make changes to the page layout of recipes versus articles and basic page.

Proposed resolution

Enable layout builder by default on all content types to make it easier for users to modify the layout of these pages. This ensures that new-to-Drupal users have a good experience and see how powerful Drupal is.

Remaining tasks

User interface changes

API changes

Data model changes

Release notes snippet

Comment	File	Size	Author
#14	interdiff_9-14.txt	982 bytes	raman.b
#14	3108503-14.patch	16.09 KB	raman.b
#14	9.2.x: PHP 7.3 & MySQL 5.7 28,006 pass
#7	interdiff_5-7.txt	373 bytes	vsujeetkumar
#7	3108503_7.patch	16.45 KB	vsujeetkumar
#7	9.1.x: PHP 7.4 & MySQL 5.7 27,907 pass, 2 fail
#5	interdiff-2-5.txt	15.49 KB	kjay
#5	drupal-umami-enable-layout-builder-ctypes-default-3108503-5.patch	16.01 KB	kjay
#5	8.9.x: PHP 7.3 & MySQL 5.7 28,490 pass, 2 fail PHP 7.3 & PostgreSQL 10.12 28,490 pass, 2 fail PHP 7.3 & SQLite 3.28 28,490 pass, 2 fail
#2	drupal-umami-enable-layout-builder-ctypes-default-3108503-2.patch	7.39 KB	kjay
#2	8.9.x: PHP 7.1 & MySQL 5.7 28,328 pass, 2 fail

Issue fork drupal-3108503

Show commands

Start within a Git clone of the project using the version control instructions.

Add & fetch this issue fork’s repository

Or, if you do not have SSH keys set up on git.drupalcode.org:

Add & fetch this issue fork’s repository

3108503-enable-layout-builder compare
Check out this branch

About issue forks

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Comment #1

24 January 2020 at 09:50

lauriii created an issue. See original summary.

Comment #2

kjay CreditAttribution: kjay commented 24 February 2020 at 08:19

Status:

Active

» Needs review

File	Size
drupal-umami-enable-layout-builder-ctypes-default-3108503-2.patch	7.39 KB
8.9.x: PHP 7.1 & MySQL 5.7 28,328 pass, 2 fail

Attached is a patch that does nothing more than enable Layout Builder for the Page and Article content types in Umami. It would be great to hear thoughts on the following notes:

I think it makes sense to allow users to vary the layout per node and so I have attempted to enable the 'Allow each content item to have its layout customized.' option on both the Page and Article content types but only Page has made this checkbox option available. Does anyone know why this is the case and do we agree it is a benefit for the demo to allow nodes to be overridden for layout?
I have created a separate issue to use layout builder for the front page of Umami, which would be a helpful UX improvement. It would be great to get some reviews of that work in progress. #3113767: Use layout builder for Umami's front page and improve the author experience

Comment #3

24 February 2020 at 09:29

Status:

Needs review

» Needs work

The last submitted patch, 2: drupal-umami-enable-layout-builder-ctypes-default-3108503-2.patch, failed testing. View results

Comment #4

markconroy CreditAttribution: markconroy at Annertech commented 25 February 2020 at 16:59

Hi @kjay

This looks great, and is a great demo of the power of Drupal OOTB.

Two items that came up during our testing:

Can we enable 'Full content' view mode for basic page and article, like we have for recipe.
You need to click the checkbox to say "Allow each content item to have its layout customized." or else the "Layout" tab is not available on the node page to let an article override the global layout.

Besides those two items, great work. Thanks.

Comment #5

kjay CreditAttribution: kjay commented 3 March 2020 at 15:31

File	Size
drupal-umami-enable-layout-builder-ctypes-default-3108503-5.patch	16.01 KB
8.9.x: PHP 7.3 & MySQL 5.7 28,490 pass, 2 fail PHP 7.3 & PostgreSQL 10.12 28,490 pass, 2 fail PHP 7.3 & SQLite 3.28 28,490 pass, 2 fail
interdiff-2-5.txt	15.49 KB

Thanks @markconroy for the review
You were right, enabling the 'Full content' display made the 'Allow each content item to have its layout customized.' option to become available.

Attached is a patch that takes care of the two points you have suggested but does not yet fix the tests.

Leaving as 'needs work' due to the tests to be done.

Comment #6

3 March 2020 at 15:31

Version:

8.9.x-dev

» 9.1.x-dev

Drupal 8.9.0-beta1 was released on March 20, 2020. 8.9.x is the final, long-term support (LTS) minor release of Drupal 8, which means new developments and disruptive changes should now be targeted against the 9.1.x-dev branch. For more information see the Drupal 8 and 9 minor version schedule and the Allowed changes during the Drupal 8 and 9 release cycles.

Comment #7

vsujeetkumar CreditAttribution: vsujeetkumar at Srijan | A Material+ Company for Drupal India Association commented 13 May 2020 at 18:01

Status:

Needs work

» Needs review

File	Size
3108503_7.patch	16.45 KB
9.1.x: PHP 7.4 & MySQL 5.7 27,907 pass, 2 fail
interdiff_5-7.txt	373 bytes

Fixed test, Please review.

Comment #8

13 May 2020 at 18:58

Status:

Needs review

» Needs work

The last submitted patch, 7: 3108503_7.patch, failed testing. View results

Comment #9

13 May 2020 at 18:58

Version:

9.1.x-dev

» 9.2.x-dev

Drupal 9.1.0-alpha1 will be released the week of October 19, 2020, which means new developments and disruptive changes should now be targeted for the 9.2.x-dev branch. For more information see the Drupal 9 minor version schedule and the Allowed changes during the Drupal 9 release cycle.

Comment #10

markconroy CreditAttribution: markconroy at Annertech commented 10 December 2020 at 21:20

Status:

Needs work

» Needs review

Setting to needs review to let the test bots do their magic.

Comment #11

markconroy CreditAttribution: markconroy at Annertech commented 11 December 2020 at 09:16

Issue tags:

+Europe2020

Adding europe2020 tag so this can be worked on during DrupalCon

Comment #12

markconroy CreditAttribution: markconroy at Annertech commented 11 December 2020 at 11:45

Status:

Needs review

» Reviewed & tested by the community

I'm going to mark this as RTBC.

It installs fine, has no custom code besides what Drupal config exports, and each content type is now using Layout Builder for "Full content" view mode.

Thanks for working on this @kjay @vsujeetkumar

Comment #13

quietone CreditAttribution: quietone as a volunteer commented 12 December 2020 at 04:43

Status:

Reviewed & tested by the community

» Needs work

Unfortunately, the latest patch has a test failure and I believe it should be testing on 9.2.x. Setting NW.

Comment #14

raman.b CreditAttribution: raman.b at OpenSense Labs commented 13 December 2020 at 18:25

Status:

Needs work

» Needs review

File	Size
3108503-14.patch	16.09 KB
9.2.x: PHP 7.3 & MySQL 5.7 28,006 pass
interdiff_9-14.txt	982 bytes

Resolving the failed test case

Comment #15

markconroy CreditAttribution: markconroy at Annertech commented 14 December 2020 at 13:52

Status:

Needs review

» Reviewed & tested by the community

Thanks for that review @quietone

Thanks for the new patch @raman.b

RTBC.

Comment #16

alexpott

he/they

English

🇪🇺🌍

CreditAttribution: alexpott at Acro Commerce, Thunder commented 22 December 2020 at 17:10

Status:

Reviewed & tested by the community

» Fixed

Committed b4311ce and pushed to 9.2.x. Thanks!

Comment #17

22 December 2020 at 17:10

alexpott committed b4311ce on 9.2.x

Issue #3108503 by kjay, raman.b, vsujeetkumar, markconroy: Enable layout...

Comment #18

5 January 2021 at 17:14

Status:

Fixed

» Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.

Comment #19

effulgentsia CreditAttribution: effulgentsia at Acquia commented 4 May 2021 at 00:45

Title:	Enable layout builder by default on all content types	» Enable layout builder by default on all content types in Umami
Issue tags:		+9.2.0 release highlights

I don't know if we want to highlight Umami stuff in the release highlights, but if we do, I think this is a worthy item to include. Tagging for now, just in case.