#2222711: meta tags not working with taxonomy terms (Views page) added metatags handling for /taxonomy/term/% when implemented as a views page instead of a core menu callback, however, the default view provided by the views module actually accepts an optional second argument making the menu callback /taxonomy/term/%/%. A URL like /taxonomy/term/123 should and does have metatags but the equivalent URL /taxonomy/term/123/all currently does not. I believe it's also reasonable to consider /taxonomy/term/123/1 or other depth modifiers for tid 123 as the entity's page and thus insert metatags there.
This can be handled with an additional special case in _metatag_entity_is_page() which checks for a second URL parameter for this specific view. We can't check that the parameter is either an integer or the string "all" since that default can be overridden (eg. on non-English sites), so we just accept any value. If there are more parameters in the URL we assume the user has some special view or other page set up and do nothing.
Comment | File | Size | Author |
---|---|---|---|
#4 | metatag-taxonomy-term-view-all-3108311-4.patch | 542 bytes | mvc |
|
Comments
Comment #2
mvcComment #3
DamienMcKennaThat patch file contains the HTML for a login page, not a git diff.
Comment #4
mvcD'oh! Let's try that again.
Comment #6
DamienMcKennaThis is a good improvement, thank you.
I modified the comment slightly to make it clear what types of paths were affected.