Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
Comment | File | Size | Author |
---|---|---|---|
#10 | interdiff.txt | 1.25 KB | pratik_kamble |
#10 | 3108252-10.patch | 756 bytes | pratik_kamble |
#3 | 3108252-3.patch | 2.44 KB | Hardik_Patel_12 |
Comments
Comment #2
Hardik_Patel_12 CreditAttribution: Hardik_Patel_12 at QED42 commentedKindly review a patch.
Comment #3
Hardik_Patel_12 CreditAttribution: Hardik_Patel_12 at QED42 commentedComment #4
Hardik_Patel_12 CreditAttribution: Hardik_Patel_12 at QED42 commentedComment #5
rogerpfaffQuite simple code change. Tests are working.
Comment #6
catchPeople often specify the key in foreaches for readability, so let's remove these hunks from the patch and open a coding standards issue if we want to standardise one way or the other.
Comment #7
rogerpfaffThe use of the key is not in general defined in the coding standards. The example in the PEAR coding standards shows it with key but all over drupal it is used in both ways. Seems like it is used where the key is needed and if not it is left out. Also in this case the key is not something special needed anywhere. I would say it's ok to keep the hunks.
Comment #8
Rangaswini CreditAttribution: Rangaswini at QED42 for Drupal India Association commentedComment #9
pratik_kambleComment #10
pratik_kambleRerolled patch to keep the key in foreach.
Comment #11
pratik_kambleComment #12
nishantghetiya CreditAttribution: nishantghetiya at QED42 commentedComment #13
nishantghetiya CreditAttribution: nishantghetiya at QED42 for Drupal India Association commented@pratik_kamble Hello,
Your patch is works well. Thanks for your contribution.
Comment #16
catchCommitted 6ef456a and pushed to 9.0.x. Thanks!