Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
Added interdiff for the patch 2 and 7.
Comment | File | Size | Author |
---|---|---|---|
#9 | interdiff-02-07.txt | 758 bytes | Rangaswini |
#9 | interdiff-02-07.txt | 758 bytes | Rangaswini |
#7 | 3107006-7.patch | 689 bytes | Rangaswini |
#2 | 3107006-2.patch | 1.4 KB | Hardik_Patel_12 |
Comments
Comment #2
Hardik_Patel_12 CreditAttribution: Hardik_Patel_12 at QED42 commentedKindly review a patch.
Comment #3
Hardik_Patel_12 CreditAttribution: Hardik_Patel_12 at QED42 commentedComment #4
snehalgaikwad CreditAttribution: snehalgaikwad at QED42 for Drupal India Association commentedI've tried this patch. Looking good to me. Unused variables are removed.
Comment #5
catchPeople often specify the key regardless of usage in foreach statements for readability. Please remove that hunk from the patch and let's open a coding standards issue if we want to standardise either way.
Comment #6
Rangaswini CreditAttribution: Rangaswini at QED42 for Drupal India Association commentedComment #7
Rangaswini CreditAttribution: Rangaswini at QED42 for Drupal India Association commented@Hardik_Patel_12 and @catch
Updated the patch as per the standards.
Comment #8
Hardik_Patel_12 CreditAttribution: Hardik_Patel_12 at QED42 commentedComment #9
Rangaswini CreditAttribution: Rangaswini at QED42 for Drupal India Association commented@Hardik_Patel_12 and @catch
Updated the patch as per the standards.
Comment #10
Rangaswini CreditAttribution: Rangaswini at QED42 for Drupal India Association commentedComment #11
Rangaswini CreditAttribution: Rangaswini at QED42 for Drupal India Association commentedComment #12
hash6 CreditAttribution: hash6 at QED42 commentedComment #13
hash6 CreditAttribution: hash6 at QED42 for Drupal India Association commentedThanks @Rangaswini for the patch, I have reviewed the above patch and we can definitely remove the unused variable ,also confirmed it in the community with @longwave as well :)
Comment #14
hash6 CreditAttribution: hash6 at QED42 for Drupal India Association commentedComment #15
catchCommitted 3459966 and pushed to 9.0.x. Thanks!