There is an issue in the hook 'xmlsitemap_form_alter'. The code for this function has been changed in the recent update and it affected the form fields on node add form. Earlier the fields were appearing in the node add form, but not we can see the fields only on the node edit form.

This also means we're missing some test coverage for this.

CommentFileSizeAuthor
#18 3106767-test-coverage.patch4.32 KBDave Reid
#16 3106767-test-coverage.patch3.18 KBDave Reid
#10 3106767-10.patch1.94 KBvoleger
#10 3106767-10-test-only.patch886 bytesvoleger
#7 Captura de tela de 2020-04-29 09-21-15.png163.13 KBilgnerfagundes
#4 3106767-node-add-form-regression-test-only.patch793 bytesDave Reid
#4 3106767-node-add-form-regression.patch1.85 KBDave Reid
#2 3106767-node-add-form-regression.patch1.08 KBDave Reid
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

er.garg.karan created an issue. See original summary.

Dave Reid’s picture

Dave Reid
he/him
Primary language English
Location Nebraska USA
CreditAttribution: Dave Reid as a volunteer and at Lullabot for Principal Financial Group commented
Issue summary: View changes
Status: Active » Needs review
FileSize
3106767-node-add-form-regression.patch1.08 KB

Yes, you're right. It appears that node/add uses the form operation of 'default', while the node/{node}/edit route has a form operation of 'edit'. So let's just make this check both for default or edit, instead of conditionally just one.

Dave Reid’s picture

Dave Reid
he/him
Primary language English
Location Nebraska USA
CreditAttribution: Dave Reid as a volunteer and at Lullabot for Principal Financial Group commented
Related issues: +#3017153: Dont add XML sitemap fields to irrelevant forms.
Dave Reid’s picture

Dave Reid
he/him
Primary language English
Location Nebraska USA
CreditAttribution: Dave Reid as a volunteer and at Lullabot for Principal Financial Group commented
FileSize
3106767-node-add-form-regression.patch1.85 KB
3106767-node-add-form-regression-test-only.patch793 bytes

Let's see if this adds the coverage we need.

andralex’s picture

andralex CreditAttribution: andralex at EPAM Systems commented
Status: Needs review » Reviewed & tested by the community

Tested and it works as expected with #4

alex_optim’s picture

alex_optim
Location 🇺🇦 Rivne
CreditAttribution: alex_optim at GOLEMS GABB, Drupal Ukraine Community for GOLEMS GABB, Drupal Ukraine Community commented

For me too.

ilgnerfagundes’s picture

ilgnerfagundes CreditAttribution: ilgnerfagundes at CI&T commented
FileSize
Captura de tela de 2020-04-29 09-21-15.png163.13 KB

The patch was applied correctly.

voleger’s picture

voleger
he/his
Primary language Ukrainian
Location Ukraine, Rivne
CreditAttribution: voleger as a volunteer and at GOLEMS GABB, Drupal Ukraine Community for Drupal Ukraine Community, GOLEMS GABB commented

Patch needs reroll

voleger’s picture

voleger
he/his
Primary language Ukrainian
Location Ukraine, Rivne
CreditAttribution: voleger as a volunteer and at GOLEMS GABB, Drupal Ukraine Community for Drupal Ukraine Community, GOLEMS GABB commented
Assigned: Unassigned » voleger
Status: Reviewed & tested by the community » Needs work

I'll reroll it

voleger’s picture

voleger
he/his
Primary language Ukrainian
Location Ukraine, Rivne
CreditAttribution: voleger as a volunteer and at GOLEMS GABB, Drupal Ukraine Community for Drupal Ukraine Community, GOLEMS GABB commented
Assigned: voleger » Unassigned
Status: Needs work » Needs review
FileSize
3106767-10-test-only.patch886 bytes
3106767-10.patch1.94 KB

Here is rerolled patch

The last submitted patch, 10: 3106767-10-test-only.patch, failed testing. View results

pifagor’s picture

pifagor
Location 🇺🇦 Rivne
CreditAttribution: pifagor at Drupal Ukraine Community, GOLEMS GABB for Drupal Ukraine Community, GOLEMS GABB commented
Status: Needs review » Reviewed & tested by the community

  • pifagor committed b228b10 on 8.x-1.x authored by voleger 
    Issue #3106767 by Dave Reid, voleger, ilgnerfagundes, er.garg.karan,...
pifagor’s picture

pifagor
Location 🇺🇦 Rivne
CreditAttribution: pifagor at Drupal Ukraine Community, GOLEMS GABB for Drupal Ukraine Community, GOLEMS GABB commented
Status: Reviewed & tested by the community » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.

Dave Reid’s picture

Dave Reid
he/him
Primary language English
Location Nebraska USA
CreditAttribution: Dave Reid as a volunteer and at Lullabot commented
Status: Closed (fixed) » Needs review
FileSize
3106767-test-coverage.patch3.18 KB

Reopening for some additional test coverage I had intended to add.

Status: Needs review » Needs work

The last submitted patch, 16: 3106767-test-coverage.patch, failed testing. View results
- codesniffer_fixes.patch Interdiff of automated coding standards fixes only.

Dave Reid’s picture

Dave Reid
he/him
Primary language English
Location Nebraska USA
CreditAttribution: Dave Reid as a volunteer and at Lullabot commented
Status: Needs work » Needs review
FileSize
3106767-test-coverage.patch4.32 KB

Ok so I needed to reset the entity access cache after saving a programmatic entity. And the form op for new users is 'register' so I added support for that.

  • Dave Reid committed b11aeaa on 8.x-1.x 
    Issue #3106767 by Dave Reid: Fixed fields not visible on user register...
Dave Reid’s picture

Dave Reid
he/him
Primary language English
Location Nebraska USA
CreditAttribution: Dave Reid as a volunteer and at Lullabot commented
Status: Needs review » Fixed

Committed #18 to 8.x-1.x. Glad to have increased test coverage around this.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.