Unused private method updateAccess() in UserBlocksTest.php file

CommentFileSizeAuthor
#2 remove_unused_function-3106215-2.patch728 bytesHardik_Patel_12
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Hardik_Patel_12 created an issue. See original summary.

Hardik_Patel_12’s picture

Hardik_Patel_12 CreditAttribution: Hardik_Patel_12 at QED42 commented
FileSize
remove_unused_function-3106215-2.patch728 bytes

Kindly review a patch.

Hardik_Patel_12’s picture

Hardik_Patel_12 CreditAttribution: Hardik_Patel_12 at QED42 commented
Assigned: Hardik_Patel_12 » Unassigned
Status: Needs work » Needs review
hash6’s picture

hash6 CreditAttribution: hash6 at QED42 for Drupal India Association commented
Assigned: Unassigned » hash6
Status: Needs review » Reviewed & tested by the community

Thanks @Hardik_Patel_12 for the patch.

hash6’s picture

hash6 CreditAttribution: hash6 at QED42 for Drupal India Association commented
Assigned: hash6 » Unassigned
alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
CreditAttribution: alexpott as a volunteer and at Acro Commerce, Thunder commented
Status: Reviewed & tested by the community » Fixed

Committed and pushed 83cb3c87d0 to 9.0.x and 791a385ae0 to 8.9.x and b3eb881ba3 to 8.8.x. Thanks!

Backported to 8.8.x as this is a private method.

This used to be used before #2895271: Convert web tests to JTB and KTB tests for user module part-3 but that converted UserBlocksTest::testWhosOnlineBlock() to a kernel test making this no longer used.

diff --git a/core/modules/user/tests/src/Functional/UserBlocksTest.php b/core/modules/user/tests/src/Functional/UserBlocksTest.php
index a57eee8ade..32d9197ac7 100644
--- a/core/modules/user/tests/src/Functional/UserBlocksTest.php
+++ b/core/modules/user/tests/src/Functional/UserBlocksTest.php
@@ -3,7 +3,6 @@
 namespace Drupal\Tests\user\Functional;
 
 use Drupal\Core\Url;
-use Drupal\Core\Database\Database;
 use Drupal\dynamic_page_cache\EventSubscriber\DynamicPageCacheSubscriber;
 use Drupal\Tests\BrowserTestBase;

Cleanup unused use on commit.

  • alexpott committed 83cb3c8 on 9.0.x 
    Issue #3106215 by Hardik_Patel_12: Unused private method updateAccess()

  • alexpott committed 791a385 on 8.9.x 
    Issue #3106215 by Hardik_Patel_12: Unused private method updateAccess...

  • alexpott committed b3eb881 on 8.8.x 
    Issue #3106215 by Hardik_Patel_12: Unused private method updateAccess...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.