CommentFileSizeAuthor
#2 3105975-2.patch562 bytesHardik_Patel_12
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Hardik_Patel_12 created an issue. See original summary.

Hardik_Patel_12’s picture

Hardik_Patel_12 CreditAttribution: Hardik_Patel_12 at QED42 commented
FileSize
3105975-2.patch562 bytes

Kindly review a new patch

Hardik_Patel_12’s picture

Hardik_Patel_12 CreditAttribution: Hardik_Patel_12 at QED42 commented
Assigned: Hardik_Patel_12 » Unassigned
Status: Active » Needs review
longwave’s picture

longwave
he/him
Primary language English
Location UK
CreditAttribution: longwave at Full Fat Things commented
Title: t() calls should be avoided in classes, use dependency |injection and $this->t() instead » t() calls should be avoided in classes, use dependency injection and $this->t() instead
Priority: Normal » Minor
Status: Needs review » Reviewed & tested by the community
Issue tags: -t() calls should be avoided in classes, -use dependency | | injection and $this->t() instead
andypost’s picture

andypost
he/him
Primary language Russian
CreditAttribution: andypost as a volunteer and at Skilld commented
Title: t() calls should be avoided in classes, use dependency injection and $this->t() instead » t() calls should be avoided in classes, use dependency injection and $this->t() instead in block module
Parent issue: » #3113904: [META] Replace t() calls inside of classes
alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
CreditAttribution: alexpott at Acro Commerce, Thunder commented
Version: 9.0.x-dev » 8.9.x-dev
Status: Reviewed & tested by the community » Fixed

Committed and pushed d384ad74af to 9.0.x and f2b9758295 to 8.9.x. Thanks!

  • alexpott committed d384ad7 on 9.0.x 
    Issue #3105975 by Hardik_Patel_12: t() calls should be avoided in...

  • alexpott committed f2b9758 on 8.9.x 
    Issue #3105975 by Hardik_Patel_12: t() calls should be avoided in...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.