Update from 4.13.0 to 4.13.1.
4.13.1 was released a few days after Drupal 8.8.0 shipped: https://ckeditor.com/blog/CKEditor-4.13.1-with-paste-improvements/
CKEditor 4.13.1 fixes lots of problems with pasting from Word, particularly in Firefox.
See also:
#1858210: [meta] Content editing experience follow-ups — in-place editing and WYSIWYG
#1950098: Update CKEditor library to 4.1
#2036253: Update CKEditor library to 4.2
#2039163: Update CKEditor library to 4.4
#2271051: Update CKEditor library to 4.4.4
#2345961: Update CKEditor library to 4.4.5
#2384581: Security: Update CKEditor library to 4.4.6
#2415111: Update CKEditor library to 4.4.7
#2521820: Update CKEditor library to 4.5.3
#2321583: Update CKEditor library to 4.5.5
#2663566: Update CKEditor library to 4.5.7
#2698587: Update CKEditor library to 4.5.8
#2724225: Update CKEditor library to 4.5.9
#2765751: Update CKEditor library to 4.5.10
#2797427: Update CKEditor library to 4.5.11
#2828494: Update CKEditor library to 4.6
#2848215: Update CKEditor library to 4.6.2
#2893566: Update CKEditor library to 4.7.1
#2904142: Update CKEditor library to 4.7.2
#2908864: Update CKEditor library to 4.7.3
#2926932: Update CKEditor library to 4.8.0
#2962330: Update CKEditor library to 4.9.2
#2983516: Update CKEditor library to 4.10.0
#2999691: Update CKEditor library to 4.10.1
#3035933: Update CKEditor to 4.11.3
#3050757: Update CKEditor to 4.11.4
#3072382: Update CKEditor to version 4.13
Release notes snippet
CKEditor has been updated from from 4.13.0 to 4.13.1, which includes numerous bugfixes and improvements.
Comment | File | Size | Author |
---|---|---|---|
#4 | 3105327--4.patch | 2.24 MB | bnjmnm |
Comments
Comment #2
Wim LeersNote: I tagged this
because this minor CKEditor bugfix release should ship with a Drupal 8.8.x bugfix release.Comment #3
Wim LeersComment #4
bnjmnmI did some basic manual testing based on what was listed in CHANGES.md, although I could only paste from google docs (I don't have Word installed). Everything seemed fine, but this should probably get a bit of additional manual testing from someone who has a better sense of what needs to be looked for with CKEditor and to confirm that the changes in this version didn't necessitate any changes to build-config.js.
Comment #5
Wim LeersI'm glad to see again somebody else managed to update our build of CKEditor :) That means the documentation is probably good enough! :D
Hah, interesting, they renamed their GitHub repo apparently!
Generally speaking, we pretty much need to do no testing. The CKEditor team has extremely thorough cross-browser testing.
I always spot-test basic functionality, plus Media nowadays, plus CKEditor toolbar configuration UI, plus Quick Edit.
I can confirm. Only bugfixes in this patch release. (Plus, we only rarely need to change the
build-config.js
anyway!The patch applies to 8.8 too btw :)
Comment #8
lauriiiI confirmed that CKEditor was updated correctly by rebuilding the package and comparing the results with
git diff --color-words=.
. Only changes between the results were hashes that are designed to be unique on every build.Confirmed that there aren't any big regressions by manually testing basic functionality, Media integration, CKEditor toolbar configuration UI, and Quick Edit.
Committed 8d60ee1 and pushed to 9.0.x and 8.9.x. Thanks! Leaving open for 8.8.x port until another committer has +1'd this.
Comment #9
xjmMy general take on backports for patch-level dependency updates is that we should still compile non-essential ones in minors, but we can ship essential ones (security fixes, major bugs, etc.) in patch releases if they're non-disruptive. This sounds like it meets the "essential" criterion, but it's harder to estimate the disruption since it's a big minified thing.
Do we have any info on potential disruptions from e.g. their commit log?
Comment #10
Wim LeersIt's right in the patch:
All of those are edge case bug fixes, many of which would benefit Drupal users too. They're 16 bug fixes, of which 4 cannot ever affect us (since they're in plugins we don't include in our build)_, and another 3 are for plugins that are not used by Drupal 8's default CKEditor configurations. There's only one API addition. All of this makes sense, given it's a patch release for them too, and not a minor.
The CKEditor team also has extremely thorough cross-browser testing. They even have long manual testing documents for those browser behaviors that cannot be automatically tested.
All of this combined: chances of breakage are extremely low.
Comment #12
xjmThanks @Wim Leers! Based on that information I've backported the patch to 8.8.x.
Comment #13
xjmComment #14
xjm