Update from 4.13.0 to 4.13.1.

4.13.1 was released a few days after Drupal 8.8.0 shipped: https://ckeditor.com/blog/CKEditor-4.13.1-with-paste-improvements/

CKEditor 4.13.1 fixes lots of problems with pasting from Word, particularly in Firefox.

See also:

#1858210: [meta] Content editing experience follow-ups — in-place editing and WYSIWYG
#1950098: Update CKEditor library to 4.1
#2036253: Update CKEditor library to 4.2
#2039163: Update CKEditor library to 4.4
#2271051: Update CKEditor library to 4.4.4
#2345961: Update CKEditor library to 4.4.5
#2384581: Security: Update CKEditor library to 4.4.6
#2415111: Update CKEditor library to 4.4.7
#2521820: Update CKEditor library to 4.5.3
#2321583: Update CKEditor library to 4.5.5
#2663566: Update CKEditor library to 4.5.7
#2698587: Update CKEditor library to 4.5.8
#2724225: Update CKEditor library to 4.5.9
#2765751: Update CKEditor library to 4.5.10
#2797427: Update CKEditor library to 4.5.11
#2828494: Update CKEditor library to 4.6
#2848215: Update CKEditor library to 4.6.2
#2893566: Update CKEditor library to 4.7.1
#2904142: Update CKEditor library to 4.7.2
#2908864: Update CKEditor library to 4.7.3
#2926932: Update CKEditor library to 4.8.0
#2962330: Update CKEditor library to 4.9.2
#2983516: Update CKEditor library to 4.10.0
#2999691: Update CKEditor library to 4.10.1
#3035933: Update CKEditor to 4.11.3
#3050757: Update CKEditor to 4.11.4
#3072382: Update CKEditor to version 4.13

Release notes snippet

CKEditor has been updated from from 4.13.0 to 4.13.1, which includes numerous bugfixes and improvements.

CommentFileSizeAuthor
#4 3105327--4.patch2.24 MBbnjmnm
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Wim Leers created an issue. See original summary.

Wim Leers’s picture

Note: I tagged this needs backport to 8.8.x because this minor CKEditor bugfix release should ship with a Drupal 8.8.x bugfix release.

Wim Leers’s picture

Issue summary: View changes
bnjmnm’s picture

Status: Active » Needs review
FileSize
2.24 MB

I did some basic manual testing based on what was listed in CHANGES.md, although I could only paste from google docs (I don't have Word installed). Everything seemed fine, but this should probably get a bit of additional manual testing from someone who has a better sense of what needs to be looked for with CKEditor and to confirm that the changes in this version didn't necessitate any changes to build-config.js.

Wim Leers’s picture

Status: Needs review » Reviewed & tested by the community

I'm glad to see again somebody else managed to update our build of CKEditor :) That means the documentation is probably good enough! :D

  1. +++ b/core/core.libraries.yml
    @@ -25,10 +25,10 @@ classList:
    -    url: https://github.com/ckeditor/ckeditor-dev/blob/4.13/LICENSE.md
    +    url: https://github.com/ckeditor/ckeditor4/blob/4.13.1/LICENSE.md
    

    Hah, interesting, they renamed their GitHub repo apparently!

  2. Everything seemed fine, but this should probably get a bit of additional manual testing from someone who has a better sense of what needs to be looked for with CKEditor

    Generally speaking, we pretty much need to do no testing. The CKEditor team has extremely thorough cross-browser testing.

    I always spot-test basic functionality, plus Media nowadays, plus CKEditor toolbar configuration UI, plus Quick Edit.

  3. and to confirm that the changes in this version didn't necessitate any changes to build-config.js.

    I can confirm. Only bugfixes in this patch release. (Plus, we only rarely need to change the build-config.js anyway!

  4. needs backport to 8.8.x

    The patch applies to 8.8 too btw :)

  • lauriii committed 8d60ee1 on 9.0.x
    Issue #3105327 by bnjmnm, Wim Leers: Update CKEditor to version 4.13.1
    

  • lauriii committed 50aa498 on 8.9.x
    Issue #3105327 by bnjmnm, Wim Leers: Update CKEditor to version 4.13.1...
lauriii’s picture

Version: 8.9.x-dev » 8.8.x-dev
Status: Reviewed & tested by the community » Patch (to be ported)

I confirmed that CKEditor was updated correctly by rebuilding the package and comparing the results with git diff --color-words=.. Only changes between the results were hashes that are designed to be unique on every build.

Confirmed that there aren't any big regressions by manually testing basic functionality, Media integration, CKEditor toolbar configuration UI, and Quick Edit.

Committed 8d60ee1 and pushed to 9.0.x and 8.9.x. Thanks! Leaving open for 8.8.x port until another committer has +1'd this.

xjm’s picture

My general take on backports for patch-level dependency updates is that we should still compile non-essential ones in minors, but we can ship essential ones (security fixes, major bugs, etc.) in patch releases if they're non-disruptive. This sounds like it meets the "essential" criterion, but it's harder to estimate the disruption since it's a big minified thing.

Do we have any info on potential disruptions from e.g. their commit log?

Wim Leers’s picture

Do we have any info on potential disruptions from e.g. their commit log?

It's right in the patch:

 CKEditor 4 Changelog
 ====================
 
+## CKEditor 4.13.1
+
+Fixed Issues:
+
+* #875: Queue Depends on Comments being enabled(https://github.com/ckeditor/ckeditor4/issues/875): Fixed: Pasting inside the editor that contains a table with the [Table Selection](https://ckeditor.com/cke4/addon/tableselection) plugin after selecting all content replaces only the table element instead of the entire content.
+* #3415: Update INSTALL with clearer/more verbose instructions(https://github.com/ckeditor/ckeditor4/issues/3415): [Firefox] Fixed: Pasting individual list elements fails. Thanks to [Jack Wickham](https://github.com/jackwickham)!
+* [#3413](https://github.com/ckeditor/ckeditor4/issues/3413): Fixed: Menu items with labels containing double quotes are rendered incorrectly.
+* #3475: Auto URL Parsing Error(https://github.com/ckeditor/ckeditor4/issues/3475): [Firefox] Fixed: Pasting plain text over existing content fails and throws an error.
+* [#2027](https://github.com/ckeditor/ckeditor4/issues/2027): Fixed: Incorrect email display text after reopening the [Link](https://ckeditor.com/cke4/addon/link) dialog for display names starting with `@`.
+* [#3544](https://github.com/ckeditor/ckeditor4/issues/3544): Fixed: The [Special Characters](https://ckeditor.com/cke4/addon/specialchar) dialog read incorrectly by screen readers due to empty table cells at the end.
+* #1653: Re: [drupal-devel] bug #1653 : striping tags in pdfview module(https://github.com/ckeditor/ckeditor4/issues/1653): Fixed: [Balloon Toolbar](https://ckeditor.com/cke4/addon/balloontoolbar) is not repositioned when the editor is scrolled with the [Div Editing Area](https://ckeditor.com/cke4/addon/divarea) feature enabled.
+* #3559: upload new admin menu 4.3 in gallery(https://github.com/ckeditor/ckeditor4/issues/3559): Fixed: [Color Dialog](https://ckeditor.com/cke4/addon/colordialog) is incorrectly positioned when used with another dialog.
+* [#3593](https://github.com/ckeditor/ckeditor4/issues/3593): Fixed: Cannot access a text or comment node when replacing an element node with them via [`CKEDITOR.htmlParser.filter`](https://ckeditor.com/docs/ckeditor4/latest/api/CKEDITOR_htmlParser_filter.html).
+* [#3524](https://github.com/ckeditor/ckeditor4/issues/3524): Fixed: The [Easy Image](https://ckeditor.com/cke4/addon/easyimage) plugin throws an error when any image with an unsupported data type is pasted into the editor.
+* [#3552](https://github.com/ckeditor/ckeditor4/issues/3352): Fixed: Incorrect value of [`CKEDITOR.plugins.widget.repository#selected`](https://ckeditor.com/docs/ckeditor4/latest/api/CKEDITOR_plugins_widget_repository.html#property-selected) after selecting the whole editor content.
+* [#3586](https://github.com/ckeditor/ckeditor4/issues/3586): Fixed: Content pasted from Microsoft Excel is not correctly recognised by the [Paste from Word](https://ckeditor.com/cke4/addon/pastefromword) plugin.
+* [#3585](https://github.com/ckeditor/ckeditor4/issues/3585): [Firefox] Fixed: Microsoft Excel content is pasted as an image.
+* [#3625](https://github.com/ckeditor/ckeditor4/issues/3625): [Firefox] Fixed: Microsoft PowerPoint content is pasted as an image.
+* #3474: feature on drupal.org, cant submit (only preview)(https://github.com/ckeditor/ckeditor4/issues/3474): Fixed: Incorrect focus order after any tab in a [dialog](https://ckeditor.com/cke4/addon/dialog) was clicked.
+* #3689: No "view inbox" in current Drupal CVS(https://github.com/ckeditor/ckeditor4/issues/3689): Fixed: Cannot change [dialog](https://ckeditor.com/cke4/addon/dialog) tabs with keyboard arrow keys after focusing any tab with a mouse click.
+
+API Changes:
+
+* [#3634](https://github.com/ckeditor/ckeditor4/issues/3634): Added the [`CKEDITOR.plugins.clipboard.dataTransfer#getTypes()`](https://ckeditor.com/docs/ckeditor4/latest/api/CKEDITOR_plugins_clipboard_dataTransfer.html#method-getTypes) method.
+
 ## CKEditor 4.13

All of those are edge case bug fixes, many of which would benefit Drupal users too. They're 16 bug fixes, of which 4 cannot ever affect us (since they're in plugins we don't include in our build)_, and another 3 are for plugins that are not used by Drupal 8's default CKEditor configurations. There's only one API addition. All of this makes sense, given it's a patch release for them too, and not a minor.

The CKEditor team also has extremely thorough cross-browser testing. They even have long manual testing documents for those browser behaviors that cannot be automatically tested.

All of this combined: chances of breakage are extremely low.

  • xjm committed 915bf60 on 8.8.x authored by lauriii
    Issue #3105327 by bnjmnm, Wim Leers: Update CKEditor to version 4.13.1...
xjm’s picture

Status: Patch (to be ported) » Fixed

Thanks @Wim Leers! Based on that information I've backported the patch to 8.8.x.

xjm’s picture

xjm’s picture

Issue tags: +8.8.3 release notes

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.