Problem/Motivation

Passing the entity.manager service to ContentEntityForm::__construct() is deprecated in Drupal 8.6.0 and will be removed before Drupal 9.0.0. Pass the entity.repository service instead. See https://www.drupal.org/node/2549139.

Proposed resolution

Replace deprecated @entity.manager in FeedForm

CommentFileSizeAuthor
#4 interdiff.txt476 bytesMegaChriz
#4 feeds-replace-deprected-@entity-manager-in-FeedForm-3104631-4.patch2.67 KBMegaChriz
#3 interdiff.txt1.58 KBMegaChriz
#3 feeds-replace-deprected-@entity-manager-in-FeedForm-3104631-3.patch2.38 KBMegaChriz
#2 feeds-Replace_deprecated_@entity.manager_in_FeedForm-3104631-2-D8.patch1.49 KBthalles
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

thalles created an issue. See original summary.

thalles’s picture

thalles
Primary language Portuguese, Brazil
Location Teófilo Otoni - MG
CreditAttribution: thalles at CI&T commented
Status: Needs work » Needs review
FileSize
feeds-Replace_deprecated_@entity.manager_in_FeedForm-3104631-2-D8.patch1.49 KB

Follow a patch.

MegaChriz’s picture

MegaChriz CreditAttribution: MegaChriz as a volunteer commented
FileSize
feeds-replace-deprected-@entity-manager-in-FeedForm-3104631-3.patch2.38 KB
interdiff.txt1.58 KB

Thanks for the patch! There were some coding standard issues with it, fixed this in attached patch. I also changed a few other things in FeedForm, for example I removed a piece of code that was there for compatibility with Drupal 8.2, a core version Feeds doesn't support anymore.

MegaChriz’s picture

MegaChriz CreditAttribution: MegaChriz as a volunteer commented
FileSize
feeds-replace-deprected-@entity-manager-in-FeedForm-3104631-4.patch2.67 KB
interdiff.txt476 bytes

Remove import of Symfony\Component\DependencyInjection\Exception\ServiceNotFoundException, since the D8.2 compatibility check was removed.

  • MegaChriz committed b41463e on 8.x-3.x authored by thalles 
    Issue #3104631 by thalles, MegaChriz: Replaced deprecated @entity....
MegaChriz’s picture

MegaChriz CreditAttribution: MegaChriz as a volunteer commented
Status: Needs review » Fixed

Committed #4.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.