Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
Problem/Motivation
Based on #3091418-25: Update composer dependencies on 9.0.x following PHP 7.2 requirement and #3091418-46: Update composer dependencies on 9.0.x following PHP 7.2 requirement we need to set a minimum version of guzzlehttp/guzzle to 6.5.2.
Proposed resolution
Set the new version, update our composer.lock file, commit.
Remaining tasks
User interface changes
API changes
Data model changes
Release notes snippet
Comment | File | Size | Author |
---|---|---|---|
#8 | 3104473-8.patch | 1.23 KB | Manuel Garcia |
#8 | interdiff-3104473-6-8.txt | 470 bytes | Manuel Garcia |
#6 | 3104473-6.patch | 1.58 KB | Manuel Garcia |
#4 | 3104473-4.patch | 91.3 KB | Manuel Garcia |
#2 | 3104473-2.patch | 131.28 KB | Manuel Garcia |
Comments
Comment #2
Manuel Garcia CreditAttribution: Manuel Garcia as a volunteer and at Appnovation for Pfizer, Inc. commentedGetting the ball rolling here:
Comment #4
Manuel Garcia CreditAttribution: Manuel Garcia as a volunteer and at Appnovation for Pfizer, Inc. commentedReroll since #3091418: Update composer dependencies on 9.0.x following PHP 7.2 requirement got in.
Comment #5
greg.1.anderson CreditAttribution: greg.1.anderson at Pantheon commented#3104265: Update Composer dependencies on Doctrine components in 9.0.x was split off from #3091418: Update composer dependencies on 9.0.x following PHP 7.2 requirement to address issues with Doctrine dependencies, so we should not be updating Doctrine here. This patch should only update Guzzle; the composer.lock should not have any additional changes (save perhaps any additional dependency updates required by Guzzle, if any).
Comment #6
Manuel Garcia CreditAttribution: Manuel Garcia as a volunteer and at Appnovation for Pfizer, Inc. commentedAh yes of course, let's try this again...
Steps taken for this patch (let me know if it makes sense):
1. Checked out
9.0.x
2. Bumped the version of guzzle to
^6.5.2
oncore/composer.json
3. Removed the vendor directory.
4. Ran
composer update guzzlehttp/guzzle
I noticed that running
composer-lock-diff
throws no results, which is strange, since clearly the lock file has changes reflecting the upgrading of guzzle... not sure what's going on there (bug in the tool?)Comment #7
longwaveThe lock file has only changed to reflect the new minimum version; the version itself was already upgraded to 6.5.2 in #3091418: Update composer dependencies on 9.0.x following PHP 7.2 requirement, so composer-lock-diff correctly shows no changes.
If I repeat the steps locally I don't get this change, I am not sure why it is added here.
Comment #8
Manuel Garcia CreditAttribution: Manuel Garcia as a volunteer and at Appnovation for Pfizer, Inc. commentedAh that makes sense, thanks @longwave for the kind explanation and for having a look at this.
Regarding the bin section being added to composer.lock, I have repeated the process a couple of times and it gets added every time. I also just did these steps after doing the steps on #6:
composer install
.I then checked the composer.lock file and the bin section was not re-added, so I'm not sure what's going on.
In any case, I'm uploading the patch without the bin configuration getting added to composer.lock in case its just something on my local set up that's causing this.
Comment #9
greg.1.anderson CreditAttribution: greg.1.anderson at Pantheon commented#8: Running
composer install
never updates the composer.lock file.In general I am -1 on hand-editing the composer.lock file; however, I repeated the steps above, and got a lock file that looked like #8, so RTBC I guess.
Were you on the 9.0.x branch when you ran
composer update
? If you check out a feature branch, then you must setCOMPOSER_ROOT_VERSION=9.0.x
to get the correct result.Comment #10
Manuel Garcia CreditAttribution: Manuel Garcia as a volunteer and at Appnovation for Pfizer, Inc. commentedRe #9: Thanks for RTBCing @greg.1.anderson
True about composer install... not sure what I was thinking... 🤦♂️
I was indeed on the 9.0.x branch (updated to latest changes) when I ran
composer update guzzlehttp/guzzle
.Anyway, so long as you get the same changes to the lock file I assume we should be ok.
Comment #11
xjmOK, this looks more like the patch I was expecting. :)
Comment #13
xjmCommitted and pushed to 9.0.x. Thanks!