Problem/Motivation

The Views module Twig files have "whtether" misspelled three times and "CSS" should be all caps like "HTML" in the line above it.

CommentFileSizeAuthor
#7 interdiff-3103976-2-7-do-not-test.diff2.03 KBDaniel Korte
#7 3103976-fix-misspellings-7.patch5.51 KBDaniel Korte
#6 interdiff-3103976-2-6-do-not-test.diff562 bytesDaniel Korte
#6 3103976-fix-misspellings-6.patch3.58 KBDaniel Korte
#4 view-twig-spellings-correction-patch.png34.83 KBPremanshu
#2 3103976-fix-misspellings-2.patch2.83 KBDaniel Korte
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Daniel Korte created an issue. See original summary.

Daniel Korte’s picture

Daniel Korte
he/him
Primary language English
Location Brooklyn, NY
CreditAttribution: Daniel Korte commented
Assigned: Daniel Korte » Unassigned
Status: Active » Needs review
FileSize
3103976-fix-misspellings-2.patch2.83 KB
Daniel Korte’s picture

Daniel Korte
he/him
Primary language English
Location Brooklyn, NY
CreditAttribution: Daniel Korte commented
Issue summary: View changes
Premanshu’s picture

Premanshu CreditAttribution: Premanshu as a volunteer and at OpenSense Labs commented
Status: Needs review » Reviewed & tested by the community
FileSize
view-twig-spellings-correction-patch.png34.83 KB

The patch provided in #2 applies cleanly.

Lendude’s picture

Lendude
Primary language Dutch
Location Amsterdam
CreditAttribution: Lendude at iO commented
Priority: Normal » Minor
Status: Reviewed & tested by the community » Needs work

@Premanshu posting a screenshot of the patch applying is not reviewing, the testbot already covers that, you need to look at the contents of the patch and review that....

+++ b/core/modules/views/templates/views-view.html.twig
@@ -5,7 +5,7 @@
- * - css_name: A css-safe version of the view name.
+ * - css_name: A CSS-safe version of the view name.

The spelling in a couple of other Views related files is lower case 'css-safe', so we would need to change the other occurrences here too.

Daniel Korte’s picture

Daniel Korte
he/him
Primary language English
Location Brooklyn, NY
CreditAttribution: Daniel Korte commented
Status: Needs work » Needs review
FileSize
3103976-fix-misspellings-6.patch3.58 KB
interdiff-3103976-2-6-do-not-test.diff562 bytes

Ah, good catch. Thanks @Lendude

Daniel Korte’s picture

Daniel Korte
he/him
Primary language English
Location Brooklyn, NY
CreditAttribution: Daniel Korte commented
FileSize
3103976-fix-misspellings-7.patch5.51 KB
interdiff-3103976-2-7-do-not-test.diff2.03 KB

Whoops. I didn't see those in the theme directories. Hopefully, that is all of them.

Daniel Korte’s picture

Daniel Korte
he/him
Primary language English
Location Brooklyn, NY
CreditAttribution: Daniel Korte commented
Lendude’s picture

Lendude
Primary language Dutch
Location Amsterdam
CreditAttribution: Lendude at iO commented
Status: Needs review » Reviewed & tested by the community

Yup, that looks like all of them! Thanks!

Premanshu’s picture

Premanshu CreditAttribution: Premanshu as a volunteer and at OpenSense Labs commented

Hi @Lendude,

I attached the screenshot just for a quick reference. And I also noticed the spelling mistakes in Views related files but seeing that the issue was made specifically for TWIG comments, I decided to mark the issue RTBC.

The above was the process that I followed. Thanks for pointing out the flaws in it.

I will try and be more careful with the process from here on.

  • lauriii committed 42c5f3c on 8.8.x 
    Issue #3103976 by Daniel Korte, Lendude: Fix misspellings in Twig...

  • lauriii committed a85d9fc on 8.9.x 
    Issue #3103976 by Daniel Korte, Lendude: Fix misspellings in Twig...
lauriii’s picture

lauriii
he/him
Primary language Finnish
Location Finland
CreditAttribution: lauriii at Acquia commented
Status: Reviewed & tested by the community » Fixed

Committed 80ce3e0 and pushed to 9.0.x, 8.9.x 8.8.x because the patch only improves documentation. Thanks!

  • lauriii committed 80ce3e0 on 9.0.x 
    Issue #3103976 by Daniel Korte, Lendude: Fix misspellings in Twig...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.