Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
When editing a machine name of a View Page (didn't check others) - An uppercase letter gives error text:
"Display name must be letters, numbers, or underscores only." This message while true, is also incomplete in describing the requirements.
Changing this from the words '... letters ...' to '... lowercase letters ...' will provide more useful information.
Comment | File | Size | Author |
---|---|---|---|
#17 | interdiff-12-17.txt | 782 bytes | jungle |
#17 | 3103010-17.patch | 1.7 KB | jungle |
#3 | Views.png | 27.01 KB | No Sssweat |
Comments
Comment #2
DamienMcKennaIn Drupal 8 the Views module was added directly to core. As a result, this issue belongs in the core issue queue, hopefully someone will be able to help you there.
Comment #3
No Sssweat CreditAttribution: No Sssweat commentedWas not able to reproduce on 8.8.5
Comment #4
No Sssweat CreditAttribution: No Sssweat commentedComment #5
No Sssweat CreditAttribution: No Sssweat commentedComment #6
No Sssweat CreditAttribution: No Sssweat commentedI see now, it's the display machine name (the machine name under the advanced section).
Comment #7
No Sssweat CreditAttribution: No Sssweat commentedComment #8
No Sssweat CreditAttribution: No Sssweat commentedI've created a patch
Comment #9
No Sssweat CreditAttribution: No Sssweat commentedComment #10
nikunj.shah CreditAttribution: nikunj.shah at QED42 commentedComment #11
LendudePatch doesn't apply, so 'needs work' for that, but the change looks good
Comment #12
AndrewsizZ CreditAttribution: AndrewsizZ as a volunteer and at AnyforSoft for AnyforSoft commentedComment #13
AndrewsizZ CreditAttribution: AndrewsizZ as a volunteer and at AnyforSoft for AnyforSoft commentedComment #16
LendudeSo the error string is tested in \Drupal\Tests\views_ui\Functional\ViewEditTest::testOtherOptions so that needs an update.
Comment #17
jungleAddressed #6
Comment #18
LendudeMarking this a task, since it is not actually a bug.
Looks good!
Comment #23
xjmThis is a good improvement. Since it changes a string, it's eligible for backport in beta, up to RC. So we're in time to get this into all of 9.1, 9.0, and 8.9. since those are in beta.
Thanks!