If user by mistakely added space before or after <none> , then title will not hide.
So we have to trim title value so it can work properly

CommentFileSizeAuthor
#6 Title_with_space_not_hiding_title-3102313-4-with-tests.patch2.59 KBmatsbla
#4 Title_with_space_not_hiding_title-3102313-4.patch1.27 KBhardik_patel_12
#4 interdiff-3102313-2-4.txt707 byteshardik_patel_12
#2 Title_with_space_not_hiding_title-3102313-2.patch627 byteshardik_patel_12

Comments

Hardik_Patel_12 created an issue. See original summary.

hardik_patel_12’s picture

hardik_patel_12 commented
Status: Active » Needs review
StatusFileSize
new Title_with_space_not_hiding_title-3102313-2.patch627 bytes

Kindly follow a patch.

matsbla’s picture

matsbla commented
Status: Needs review » Needs work

Hmm.
In that case, to keep it consistent, we should do the same for the view field display:
https://git.drupalcode.org/project/none_title/blob/8.x-1.x/src/Plugin/vi...
If not the title will still be displayed in views.

hardik_patel_12’s picture

hardik_patel_12 commented
Status: Needs work » Needs review
StatusFileSize
new interdiff-3102313-2-4.txt707 bytes
new Title_with_space_not_hiding_title-3102313-4.patch1.27 KB

Kindly follow a new patch.

snehalgaikwad’s picture

snehalgaikwad commented
Status: Needs review » Reviewed & tested by the community

Patch is working fine. Title is getting hidden in both views and node pages even after adding spaces.

matsbla’s picture

matsbla commented
StatusFileSize
new Title_with_space_not_hiding_title-3102313-4-with-tests.patch2.59 KB

Adding tests

  • matsbla committed 3167bf3 on 8.x-1.x 
    Issue #3102313 by Hardik_Patel_12, matsbla: If title added as <none>...
matsbla’s picture

matsbla commented
Status: Reviewed & tested by the community » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.