Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
The Logger file uses dependency injection to inject the Messenger service. To properly support dependency injection, it should typehint using the MessengerInterface. It currently typehints with Core's Messenger service directly, which breaks things if any other module were to swap the Messenger service with their own.
Comment | File | Size | Author |
---|---|---|---|
#2 | simple_sitemap-support_swapping_messenger-3102084-2.patch | 1.08 KB | ashrafabed |
|
Comments
Comment #2
ashrafabedPatch is attached. This is fairly straightforward, merging it won't impact anything negatively.
Comment #4
gbyte CreditAttribution: gbyte as a volunteer and commentedDone, thanks for the patch! Not a bug tough.
Comment #5
ashrafabedWas marked as a bug because when a different module which overrode the messenger service was installed, simple_sitemap took my site down. Thanks for merging it so quickly!