Follow-up to #2849628: Copy change to Views UI module [#3101787]

Problem/Motivation

It seems like #2849628: Strange bar in View UI filters Modal when there are no filter options was only applied to Stable whereas it should have been applied to both, Views UI and Stable.

Proposed resolution

Copy the change to Views UI module so that the change can be shipped also in the new Stable 9 theme.

Comment	File	Size	Author
#3	3101787-3.patch	482 bytes	lauriii
#3	8.9.x: PHP 7.1 & MySQL 5.7 28,132 pass

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Comment #1

18 December 2019 at 10:58

lauriii created an issue. See original summary.

Comment #2

lauriii

he/him

Finnish

Finland

CreditAttribution: lauriii at Acquia commented 18 December 2019 at 10:58

Parent issue:

» #2849628: Strange bar in View UI filters Modal when there are no filter options

Comment #3

lauriii

he/him

Finnish

Finland

CreditAttribution: lauriii at Acquia commented 18 December 2019 at 11:00

Status:

Active

» Needs review

File	Size
3101787-3.patch	482 bytes
8.9.x: PHP 7.1 & MySQL 5.7 28,132 pass

Comment #4

lauriii

he/him

Finnish

Finland

CreditAttribution: lauriii at Acquia commented 18 December 2019 at 14:46

Title:

Follow-up to #2849628: Copy change to Views UI

» Follow-up to #2849628: Copy change to Views UI module

Comment #6

24 December 2019 at 20:13

xjm committed 58bec68 on 9.0.x

Issue #3101787 by lauriii: Follow-up to #2849628: Copy change to Views...

Comment #7

24 December 2019 at 20:14

xjm committed 9bef736 on 8.9.x

Issue #3101787 by lauriii: Follow-up to #2849628: Copy change to Views...

Comment #8

24 December 2019 at 20:14

xjm committed b507e98 on 8.8.x

Issue #3101787 by lauriii: Follow-up to #2849628: Copy change to Views...

Comment #9

xjm

she/her

English

CreditAttribution: xjm at Acquia commented 24 December 2019 at 20:14

Status:

Reviewed & tested by the community

» Fixed

Oh yeah, even I can see that the original issue not including module CSS was an oops. Not sure why I didn't see it at the time... :P

The original issue was backported to 8.3.x during its alpha phase. The only possibility of disruption here now is for themes that don't even extend Stable, and this is a straight-up bugfix for them anyway, so I think it's also safe to backport for an 8.8.x patch release. So, I've committed this to 9.0.x, and cherry-picked it to both 8.9.x and 8.8.x.

Thanks!