Drupal 8.8.x+ - Notice: Undefined index: field_name [#3101345]

After updating to Drupal 8.8.0 (with JSONAPI Extras 3.13.0) I receive the following notice:

Notice: Undefined index: field_name in Drupal\jsonapi_extras\Normalizer\ResourceIdentifierNormalizer->normalize() (line 47 of /srv/bindings/5e4b18c156474972b1247154adc08a2b/code/web/modules/contrib/jsonapi_extras/src/Normalizer/ResourceIdentifierNormalizer.php) #0 /srv/bindings/5e4b18c156474972b1247154adc08a2b/code/web/core/includes/bootstrap.inc(596): _drupal_error_handler_real(8, 'Undefined index...', '/srv/bindings/5...', 47, Array) #1 /srv/bindings/5e4b18c156474972b1247154adc08a2b/code/web/modules/contrib/jsonapi_extras/src/Normalizer/ResourceIdentifierNormalizer.php(47): _drupal_error_handler(8, 'Undefined index...', '/srv/bindings/5...', 47, Array) #2 /srv/bindings/5e4b18c156474972b1247154adc08a2b/code/vendor/symfony/serializer/Serializer.php(143): Drupal\jsonapi_extras\Normalizer\ResourceIdentifierNormalizer->normalize(Object(Drupal\jsonapi\JsonApiResource\ResourceIdentifier), 'api_json', Array) #3 /srv/bindings/5e4b18c156474972b1247154adc08a2b/code/web/core/modules/jsonapi/src/Serializer/Serializer.php(62): Symfony\Component\Serializer\Serializer->normalize(Object(Drupal\jsonapi\JsonApiResource\ResourceIdentifier), 'api_json', Array) #4 /srv/bindings/5e4b18c156474972b1247154adc08a2b/code/web/core/modules/jsonapi/src/Normalizer/DataNormalizer.php(26): Drupal\jsonapi\Serializer\Serializer->normalize(Object(Drupal\jsonapi\JsonApiResource\ResourceIdentifier), 'api_json', Array) #5 [internal function]: Drupal\jsonapi\Normalizer\DataNormalizer->Drupal\jsonapi\Normalizer\{closure}(Object(Drupal\jsonapi\JsonApiResource\ResourceIdentifier)) #6 /srv/bindings/5e4b18c156474972b1247154adc08a2b/code/web/core/modules/jsonapi/src/Normalizer/DataNormalizer.php(27): array_map(Object(Closure), Array) #7 /srv/bindings/5e4b18c156474972b1247154adc08a2b/code/vendor/symfony/serializer/Serializer.php(143): Drupal\jsonapi\Normalizer\DataNormalizer->normalize(Object(Drupal\jsonapi\JsonApiResource\RelationshipData), 'api_json', Array) #8 /srv/bindings/5e4b18c156474972b1247154adc08a2b/code/web/core/modules/jsonapi/src/Serializer/Serializer.php(62): Symfony\Component\Serializer\Serializer->normalize(Object(Drupal\jsonapi\JsonApiResource\RelationshipData), 'api_json', Array) #9 /srv/bindings/5e4b18c156474972b1247154adc08a2b/code/web/core/modules/jsonapi/src/Normalizer/RelationshipNormalizer.php(26): Drupal\jsonapi\Serializer\Serializer->normalize(Object(Drupal\jsonapi\JsonApiResource\RelationshipData), 'api_json', Array) #10 /srv/bindings/5e4b18c156474972b1247154adc08a2b/code/vendor/symfony/serializer/Serializer.php(143): Drupal\jsonapi\Normalizer\RelationshipNormalizer->normalize(Object(Drupal\jsonapi\JsonApiResource\Relationship), 'api_json', Array) #11 /srv/bindings/5e4b18c156474972b1247154adc08a2b/code/web/core/modules/jsonapi/src/Serializer/Serializer.php(62): Symfony\Component\Serializer\Serializer->normalize(Object(Drupal\jsonapi\JsonApiResource\Relationship), 'api_json', Array) #12 /srv/bindings/5e4b18c156474972b1247154adc08a2b/code/web/core/modules/jsonapi/src/Normalizer/ResourceObjectNormalizer.php(187): Drupal\jsonapi\Serializer\Serializer->normalize(Object(Drupal\jsonapi\JsonApiResource\Relationship), 'api_json', Array) #13 /srv/bindings/5e4b18c156474972b1247154adc08a2b/code/web/core/modules/jsonapi/src/Normalizer/ResourceObjectNormalizer.php(121): Drupal\jsonapi\Normalizer\ResourceObjectNormalizer->serializeField(Object(Drupal\Core\Field\EntityReferenceFieldItemList), Array, 'api_json') #14 /srv/bindings/5e4b18c156474972b1247154adc08a2b/code/web/core/modules/jsonapi/src/Normalizer/ResourceObjectNormalizer.php(73): Drupal\jsonapi\Normalizer\ResourceObjectNormalizer->getNormalization(Array, Object(Drupal\jsonapi\JsonApiResource\ResourceObject), 'api_json', Array) #15 /srv/bindings/5e4b18c156474972b1247154adc08a2b/code/web/modules/contrib/jsonapi_extras/src/Normalizer/JsonApiNormalizerDecoratorBase.php(38): Drupal\jsonapi\Normalizer\ResourceObjectNormalizer->normalize(Object(Drupal\jsonapi\JsonApiResource\ResourceObject), 'api_json', Array) #16 /srv/bindings/5e4b18c156474972b1247154adc08a2b/code/web/modules/contrib/jsonapi_extras/src/Normalizer/ResourceObjectNormalizer.php(24): Drupal\jsonapi_extras\Normalizer\JsonApiNormalizerDecoratorBase->normalize(Object(Drupal\jsonapi\JsonApiResource\ResourceObject), 'api_json', Array) #17 /srv/bindings/5e4b18c156474972b1247154adc08a2b/code/vendor/symfony/serializer/Serializer.php(143): Drupal\jsonapi_extras\Normalizer\ResourceObjectNormalizer->normalize(Object(Drupal\jsonapi\JsonApiResource\ResourceObject), 'api_json', Array) #18 /srv/bindings/5e4b18c156474972b1247154adc08a2b/code/web/core/modules/jsonapi/src/Serializer/Serializer.php(62): Symfony\Component\Serializer\Serializer->normalize(Object(Drupal\jsonapi\JsonApiResource\ResourceObject), 'api_json', Array) #19 /srv/bindings/5e4b18c156474972b1247154adc08a2b/code/web/core/modules/jsonapi/src/Normalizer/DataNormalizer.php(26): Drupal\jsonapi\Serializer\Serializer->normalize(Object(Drupal\jsonapi\JsonApiResource\ResourceObject), 'api_json', Array) #20 [internal function]: Drupal\jsonapi\Normalizer\DataNormalizer->Drupal\jsonapi\Normalizer\{closure}(Object(Drupal\jsonapi\JsonApiResource\ResourceObject)) #21 /srv/bindings/5e4b18c156474972b1247154adc08a2b/code/web/core/modules/jsonapi/src/Normalizer/DataNormalizer.php(27): array_map(Object(Closure), Array) #22 /srv/bindings/5e4b18c156474972b1247154adc08a2b/code/vendor/symfony/serializer/Serializer.php(143): Drupal\jsonapi\Normalizer\DataNormalizer->normalize(Object(Drupal\jsonapi\JsonApiResource\ResourceObjectData), 'api_json', Array) #23

Patch to follow.

Comment	File	Size	Author
#31	3101345-drupal-9.3-support.patch	647 bytes	hari604
#31
#24	3101345--field-name--24.patch	4.08 KB	e0ipso
#24	8.x-3.x: PHP 7.2 & MySQL 5.5, D8.8.3 Skipped, branch did not pass for 4 weeks
#22	Notice-Undefined-variable-enhancer-3101345-21.patch	1.69 KB	taras.suliatitskiy
#22	8.x-3.x: PHP 7.2 & MySQL 5.5, D8.8.3 Skipped, branch did not pass for 4 weeks
#20	interdiff_19-20.txt	1.15 KB	devoidfury
#20	Drupal-8.8.0-Notice-Undefined-index-field_name-3101345-20.patch	1.67 KB	devoidfury
#20	8.x-3.x: PHP 7.2 & MySQL 5.5, D8.8.3 6 pass, 4 fail
#19	3101345-19-check-empty-resource_object-before-calling-getResourceType.patch	1.63 KB	franck_lorancy
#19	8.x-3.x: PHP 7.2 & MySQL 5.5, D8.8.3 Skipped, branch did not pass for 4 weeks
#17	interdiff_13-17.txt	1016 bytes	devoidfury
#17	Drupal-8.8.0-Notice-Undefined-index-field_name-3101345-17.patch	1.29 KB	devoidfury
#17	8.x-3.x: PHP 7.2 & MySQL 5.5, D8.8.3 Skipped, branch did not pass for 4 weeks
#13	Drupal-8.8.0-Notice-Undefined-index-field_name-3101345-13.patch	1.21 KB	jlockhart
#13	8.x-3.x: PHP 7.2 & MySQL 5.5, D8.8.1 6 pass, 4 fail PHP 7.2 & MySQL 5.5, D8.8 6 pass, 4 fail
#10	3101345-10.patch	1.13 KB	dmitry.korhov
#10	8.x-3.x: PHP 7.2 & MySQL 5.5, D8.8.1 6 pass, 4 fail PHP 7.2 & MySQL 5.5, D8.8 6 pass, 4 fail
#9	3101345-9.patch	1.11 KB	dmitry.korhov
#9	8.x-3.x: PHP 7.2 & MySQL 5.5, D8.8.1 Skipped, branch did not pass for 4 weeks PHP 7.2 & MySQL 5.5, D8.8 5 pass, 6 fail PHP 7.2 & MySQL 5.5, D8.7 5 pass, 6 fail
#8	3101345-8.patch	1.05 KB	dmitry.korhov
#8	8.x-3.x: PHP 7.2 & MySQL 5.5, D8.8.1 Skipped, branch did not pass for 4 weeks PHP 7.2 & MySQL 5.5, D8.9 5 pass, 6 fail
#3	3101345-3.patch	797 bytes	taras.suliatitskiy
#3	8.x-3.x: PHP 7.2 & MySQL 5.5, D8.8.0 6 pass, 4 fail
#2	3101345-2.patch	937 bytes	briangonzalezmia
#2	8.x-3.x: PHP 7.2 & MySQL 5.5, D8.8.0 Patch Failed to Apply

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Comment #1

16 December 2019 at 15:28

briangonzalezmia created an issue. See original summary.

Comment #2

briangonzalezmia

English

Miami

CreditAttribution: briangonzalezmia as a volunteer commented 16 December 2019 at 15:30

File	Size
3101345-2.patch	937 bytes
8.x-3.x: PHP 7.2 & MySQL 5.5, D8.8.0 Patch Failed to Apply

Comment #3

taras.suliatitskiy CreditAttribution: taras.suliatitskiy commented 16 December 2019 at 17:15

File	Size
3101345-3.patch	797 bytes
8.x-3.x: PHP 7.2 & MySQL 5.5, D8.8.0 6 pass, 4 fail

3101345-3.patch
Just a small update to the module path to make it applicable.

Comment #4

briangonzalezmia

English

Miami

CreditAttribution: briangonzalezmia as a volunteer commented 16 December 2019 at 17:18

Thanks! @taras.suliatitskiy

Comment #5

Grimreaper

French

France 🇫🇷

CreditAttribution: Grimreaper at Smile commented 17 December 2019 at 10:00

Status:

Active

» Needs review

Hello,

Thanks for the issue and the patch.

I think it is something that makes automated tests failure in the Entity share module: https://www.drupal.org/pift-ci-job/1511076

https://www.drupal.org/project/entity_share/issues/3101334

I will see if I can apply the patch for automated tests on drupal.org.

Comment #6

Grimreaper

French

France 🇫🇷

CreditAttribution: Grimreaper at Smile commented 17 December 2019 at 14:50

I confirm that patch from comment 3 fixes the automated tests of Entity share module, Thanks!

I am still dealing with other deprecation notices.

Comment #7

markie CreditAttribution: markie at Mediacurrent commented 26 December 2019 at 22:10

Status:

Needs review

» Needs work

While the patch does squash the error message, it does not resolve the overall problem. It appears that 'field_name' is never passed into context anymore, which means any enhancers added to an entity field will never get picked up. I am trying to add a custom field enhancer to an audio field, and I can never get the code to fire because the default normalized output is all that is returned. I have debugged both the media--audio entity and even just tried adding the enhancer to the audio field on the content type, but not one is the enhancer triggered. I put some watchdog notices in my code just to make sure. My custom fieldEnhancer was working previously, but one I upgraded to 8.8.1, and the core jsonapi, this is failing.

Comment #8

dmitry.korhov

English

Poland, Warsaw

CreditAttribution: dmitry.korhov at EPAM Systems commented 7 February 2020 at 17:25

Status:

Needs work

» Needs review

File	Size
3101345-8.patch	1.05 KB
8.x-3.x: PHP 7.2 & MySQL 5.5, D8.8.1 Skipped, branch did not pass for 4 weeks PHP 7.2 & MySQL 5.5, D8.9 5 pass, 6 fail

Let's try to apply this patch.
$context['field_name'] was removed in JSON:API in Drupal 8.8.0 so we can not use it as a field identifier for Resource.

Comment #9

dmitry.korhov

English

Poland, Warsaw

CreditAttribution: dmitry.korhov at EPAM Systems commented 7 February 2020 at 18:54

File	Size
3101345-9.patch	1.11 KB
8.x-3.x: PHP 7.2 & MySQL 5.5, D8.8.1 Skipped, branch did not pass for 4 weeks PHP 7.2 & MySQL 5.5, D8.8 5 pass, 6 fail PHP 7.2 & MySQL 5.5, D8.7 5 pass, 6 fail

Comment #10

dmitry.korhov

English

Poland, Warsaw

CreditAttribution: dmitry.korhov at EPAM Systems commented 8 February 2020 at 07:40

File	Size
3101345-10.patch	1.13 KB
8.x-3.x: PHP 7.2 & MySQL 5.5, D8.8.1 6 pass, 4 fail PHP 7.2 & MySQL 5.5, D8.8 6 pass, 4 fail

2 files were hidden/shown/deleted

File	Size
3101345-8.patch	1.05 KB
8.x-3.x: PHP 7.2 & MySQL 5.5, D8.8.1 Skipped, branch did not pass for 4 weeks PHP 7.2 & MySQL 5.5, D8.9 5 pass, 6 fail
3101345-9.patch	1.11 KB
8.x-3.x: PHP 7.2 & MySQL 5.5, D8.8.1 Skipped, branch did not pass for 4 weeks PHP 7.2 & MySQL 5.5, D8.8 5 pass, 6 fail PHP 7.2 & MySQL 5.5, D8.7 5 pass, 6 fail

Comment #11

8 February 2020 at 07:51

Status:

Needs review

» Needs work

The last submitted patch, 10: 3101345-10.patch, failed testing. View results

Comment #12

dmitry.korhov

English

Poland, Warsaw

CreditAttribution: dmitry.korhov at EPAM Systems commented 8 February 2020 at 08:02

Status:

Needs work

» Needs review

Comment #13

jlockhart

English

PNW Washington

CreditAttribution: jlockhart at Cellar Door commented 11 February 2020 at 21:11

File	Size
Drupal-8.8.0-Notice-Undefined-index-field_name-3101345-13.patch	1.21 KB
8.x-3.x: PHP 7.2 & MySQL 5.5, D8.8.1 6 pass, 4 fail PHP 7.2 & MySQL 5.5, D8.8 6 pass, 4 fail

Thanks for the work on this patch; really helped point me in the right direction. I did run into a couple of things when applying it.

1. I had an issue with instanceof and namespacing. My use case is for the Webforms module which extends EntityReferenceFieldItemList. So it wasn't returning true for their class. I've updated the check to include namespace.

2. This actually exposed another issue. IF there aren't any referenced entities, then the second check will throw an error. So I've added a check to make sure that there are entities before trying to match them.

With both of these updates this has resolved the issue of my webforms enhancer not working.

Comment #14

12 February 2020 at 08:50

Status:

Needs review

» Needs work

The last submitted patch, 13: Drupal-8.8.0-Notice-Undefined-index-field_name-3101345-13.patch, failed testing. View results
- codesniffer_fixes.patch Interdiff of automated coding standards fixes only.

Comment #15

bachbach CreditAttribution: bachbach commented 18 February 2020 at 16:23

hi,
patch #13 is working for me

Comment #16

Morbus Iff

they/them

CreditAttribution: Morbus Iff commented 5 March 2020 at 13:47

Title:	Drupal 8.8.0 - Notice: Undefined index: field_name	» Drupal 8.8.x+ - Notice: Undefined index: field_name
Status:	Needs work	» Reviewed & tested by the community

Patch #13 is also working for me. Not sure about the test errors.

Bumping for maintainer look-see.

Comment #17

devoidfury CreditAttribution: devoidfury as a volunteer and at Mobomo commented 9 March 2020 at 15:57

File	Size
Drupal-8.8.0-Notice-Undefined-index-field_name-3101345-17.patch	1.29 KB
8.x-3.x: PHP 7.2 & MySQL 5.5, D8.8.3 Skipped, branch did not pass for 4 weeks
interdiff_13-17.txt	1016 bytes

Patch #13 was mostly working for me, but it was throwing the following error sometimes in production:

Error: Call to a member function uuid() on null in docroot/modules/contrib/jsonapi_extras/src/Normalizer/ResourceIdentifierNormalizer.php on line 51
#0 vendor/symfony/serializer/Serializer.php(143): Drupal\jsonapi_extras\Normalizer\ResourceIdentifierNormalizer->normalize(Object(Drupal\jsonapi\JsonApiResource\ResourceIdentifier), 'api_json', Array)

I adjusted the patch to take into account NULL potentially being present in relatedEntities. If there's a better way to handle this let me know and I'll adjust the patch.

Comment #18

devoidfury CreditAttribution: devoidfury as a volunteer and at Mobomo commented 9 March 2020 at 15:58

Status:

Reviewed & tested by the community

» Needs review

Comment #19

franck_lorancy CreditAttribution: franck_lorancy commented 12 March 2020 at 09:53

File	Size
3101345-19-check-empty-resource_object-before-calling-getResourceType.patch	1.63 KB
8.x-3.x: PHP 7.2 & MySQL 5.5, D8.8.3 Skipped, branch did not pass for 4 weeks

Thanks #17 works I had a condition to check if $context['resource_object'] is empty before calling getResourceType()
This refered to another issue : 3105165

Comment #20

devoidfury CreditAttribution: devoidfury as a volunteer and at Mobomo commented 17 March 2020 at 17:10

File	Size
Drupal-8.8.0-Notice-Undefined-index-field_name-3101345-20.patch	1.67 KB
8.x-3.x: PHP 7.2 & MySQL 5.5, D8.8.3 6 pass, 4 fail
interdiff_19-20.txt	1.15 KB

Revised patch prevents `Undefined offset: 0` notices.

Comment #21

20 March 2020 at 10:05

Status:

Needs review

» Needs work

The last submitted patch, 20: Drupal-8.8.0-Notice-Undefined-index-field_name-3101345-20.patch, failed testing. View results
- codesniffer_fixes.patch Interdiff of automated coding standards fixes only.

Comment #22

taras.suliatitskiy CreditAttribution: taras.suliatitskiy at FFW for NBCUniversal commented 27 March 2020 at 19:33

File	Size
Notice-Undefined-variable-enhancer-3101345-21.patch	1.69 KB
8.x-3.x: PHP 7.2 & MySQL 5.5, D8.8.3 Skipped, branch did not pass for 4 weeks

Getting Notice: Undefined variable: enhancer in Drupal\jsonapi_extras\Normalizer\ResourceIdentifierNormalizer->normalize() (line 65 of /var/www/docroot/modules/contrib/jsonapi_extras/src/Normalizer/ResourceIdentifierNormalizer.php) with patch from #20. Added small sanity check to fix that.

Comment #23

szato CreditAttribution: szato at Brainsum for Tieto commented 27 March 2020 at 23:05

Status:

Needs work

» Needs review

Comment #24

e0ipso

Catalan

Can Picafort

CreditAttribution: e0ipso as a volunteer and at Lullabot commented 28 March 2020 at 22:48

File	Size
3101345--field-name--24.patch	4.08 KB
8.x-3.x: PHP 7.2 & MySQL 5.5, D8.8.3 Skipped, branch did not pass for 4 weeks

I went with a different direction based on the patch here.

Comment #25

28 March 2020 at 22:49

e0ipso committed 6b9dbaa on 8.x-3.x authored by dmitry.korhov

Issue #3101345 by dmitry.korhov, devoidfury, taras.suliatitskiy,...

Comment #26

e0ipso

Catalan

Can Picafort

CreditAttribution: e0ipso as a volunteer and at Lullabot commented 28 March 2020 at 22:49

Status:

Needs review

» Fixed

Merged, as the failures are unrelated.

Comment #27

e0ipso

Catalan

Can Picafort

CreditAttribution: e0ipso as a volunteer and at Lullabot commented 29 March 2020 at 19:39

Thanks everyone involved in this issue. Free software maintainers need your contributions, and you didn't fail to deliver. ✨

Comment #28

vensires CreditAttribution: vensires commented 31 March 2020 at 06:18

@e0ipso that's one of the kindest comments I have read! Way to go sire :)

Comment #29

14 April 2020 at 06:19

Status:

Fixed

» Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.

Comment #30

hari604 CreditAttribution: hari604 as a volunteer and at Appinfini commented 20 April 2022 at 14:21

The previously shared patches were not working for me on Drupal 9.3.11.
Thus sharing this patch which has a minor change which exposes "field_name".

Comment #31

hari604 CreditAttribution: hari604 as a volunteer and at Appinfini commented 20 April 2022 at 14:49

File	Size
3101345-drupal-9.3-support.patch	647 bytes

The previously shared patches were not working for me on Drupal 9.3.11.
Thus sharing this patch which has a minor change which exposes "field_name".

Comment #32

vensires CreditAttribution: vensires commented 21 April 2022 at 13:18

@hari604, this is marked as fixed and closed.

If you encountered it again, you should create a new issue, relate it to this one and set as affected version the latest 8.3-3.x release of this module.

Comment #33

hari604 CreditAttribution: hari604 as a volunteer and at Appinfini commented 14 May 2022 at 13:39

@vensires
Sorry, I was not aware of that and though to post in this issue to get further resolution.
I have now created a new issue with another patch for D9.3.11 and 8.3-3.x release:
https://www.drupal.org/project/jsonapi_extras/issues/3280480

Drupal 8.8.x+ - Notice: Undefined index: field_name

Comments

Referenced by