Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
PHP 5.6 introduced constant expressions (see https://www.php.net/manual/en/migration56.new-features.php). This is something the JSON:API module wanted to use, but could not, because it had to support PHP 5.5 too. Drupal 8.8.0 having dropped support for PHP 5.5 allows us to use it after all.
Release notes snippet
JsonApiSpec::RESERVED_QUERY_PARAMETERS
has changed from a string to an array.
Comment | File | Size | Author |
---|---|---|---|
#5 | 3100591-5.patch | 2.69 KB | Hardik_Patel_12 |
#5 | interdiff-3100591-2-5.txt | 928 bytes | Hardik_Patel_12 |
Comments
Comment #2
Wim LeersComment #3
Wim LeersComment #4
Krzysztof DomańskiDue to coding standards, I change to "Needs work".
1. Two spaces after "=".
const MEMBER_NAME_REGEXP = '/^' .
2. A comma should follow the last multiline array item.
3. The following code is more readable, but coding standards report an error here... "String concat is not required here; use a single string instead".
We should decide whether more readable code (add
@codingStandardsIgnoreStart
)or better coding standards
Comment #5
Hardik_Patel_12 CreditAttribution: Hardik_Patel_12 commentedResolving coding standards as suggested in #4.
Comment #6
Krzysztof DomańskiComment #8
Krzysztof DomańskiUnrelated test failure.
Comment #10
catchThis changes the value of a constant. I can't imagine anyone is relying on it, but probably makes this a 9.x-only change.
Added a release notes snippet just in case, I feel like a change record would be overkill here though.
Committed 2f2dc41 and pushed to 9.0.x. Thanks!
Comment #11
Wim Leers#10:
🙂
I'm fine with this being 9.x-only.
Thanks for the thoughtful comment, @catch!
Comment #12
xjm@catch and I agreed that this is too minor to mention in the release notes.