Problem/Motivation

In update_calculate_project_update_status() in update.compare.inc

An intended call to UpdateManagerInterface::NOT_SECURE is misspelled as UpdateManagerInterfac::NOT_SECURE

  if (isset($available['project_status'])) {
    switch ($available['project_status']) {
      case 'insecure':
        $project_data['status'] = UpdateManagerInterfac::NOT_SECURE;
        if (empty($project_data['extra'])) {
          $project_data['extra'] = [];
        }

This change happened less than a week ago in #3015810: Properly deprecate UPDATE_* constants.

Proposed resolution

Fix the typo
Open a followup to expand test coverage so this could be caught more easily: #3100448: Expand test coverage for update_calculate_project_update_status()

Remaining tasks

.

User interface changes

.

API changes

.

Data model changes

Release notes snippet

CommentFileSizeAuthor
#2 3100444-2.patch670 bytesbnjmnm
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

bnjmnm created an issue. See original summary.

bnjmnm’s picture

Title: typo in update.compare.inc results in calling a existent resource » typo in update.compare.inc results in calling a non-existent resource
Status: Active » Needs review
FileSize
670 bytes
bnjmnm’s picture

Issue summary: View changes
Wim Leers’s picture

Issue tags: +Trivial patch of the month

🚢

longwave’s picture

Status: Needs review » Reviewed & tested by the community
Issue tags: +Quick fix
Wim Leers’s picture

Oops, yes, I meant to mark this RTBC 😅

Gábor Hojtsy’s picture

  • Gábor Hojtsy committed 5ca2b4e on 9.0.x
    Issue #3100444 by bnjmnm, Wim Leers, longwave: typo in update.compare....

  • Gábor Hojtsy committed 266f639 on 8.9.x
    Issue #3100444 by bnjmnm, Wim Leers, longwave: typo in update.compare....
Gábor Hojtsy’s picture

Status: Reviewed & tested by the community » Fixed

Whoops, thanks. I agree there should be tests so we don't just accidentally bump into this. #3100448: Expand test coverage for update_calculate_project_update_status()

Wim Leers’s picture

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.