Drupal 9 compatibility

I haven’t checked yet if Feeds Tamper is ready for Drupal 9.

The error message you get implies that you may not have the latest version of the Tamper module installed.

It looks like the module has no deprecated code usages, so we just need to mark it as compatible with D9.

So, add core_version_requirement: ^8 || ^9 to info.yml file, and also add the composer.json definition per https://www.drupal.org/node/3070687.

Please review the patch.

+++ b/feeds_tamper.info.yml
@@ -2,6 +2,7 @@ name: Feeds Tamper
   - drupal:system (>=8.5.0)

Tests fail on Drupal 9 because there's a dependency on drupal:system >=8.5.0:

drupal/feeds_tamper dev-2.x requires drupal/core ^8.5.0 -> satisfiable by drupal/core[8.5.x-dev, 8.7.x-dev, 8.8.x-dev, 8.9.x-dev]

What's the proper way to minimal require Drupal 8.5 and be compatible with Drupal 9? Or should we raise the minimum requirement to 8.7.7?

Hi, @MegaChriz Thanks for the review, I have updated the info.yml, please review the patch.

From https://www.drupal.org/pift-ci-job/1634871:

The 'core_version_requirement' can not be used to specify compatibility for a specific version before 8.7.7 in modules/contrib/feeds_tamper/feeds_tamper.info.yml

So requiring at least Drupal 8.5 must be done in an other way.

Similar issue: #3106675: Composer core restraint prevents module from installing on D9

Please review the patch.

The 'core_version_requirement' constraint (^8.7.7 || ^9) requires the 'core' key not be set in modules/contrib/feeds_tamper/feeds_tamper.info.yml

Maybe there's no way to require at least Drupal 8.5 and be compatible with Drupal 9. The only options so far seem to be:

1. Be compatible with any Drupal 8 version and Drupal 9.
2. Be compatible with only Drupal 8.7.7 and up and Drupal 9.

I could ask a question about it in Slack, otherwise I think we would need to go for option 2 here. The latest release of Feeds is already requiring at least Drupal 8.7 and its next release will require at least Drupal 8.8. I think the situation where someone only wants to update Feeds Tamper and not Feeds is probably rare.

When working on D9 compatibility for Feeds, it looks like the testbot cannot test the module with Drupal 9 when D9 compatibility is only declared in a patch (see #3042774-49: Drupal 9 Deprecated Code Report).

So I committed #3 for now.

Ah of course, the Tamper module needs to be made compatible with D9 first:

drupal/tamper 1.x-dev requires drupal/core ~8.0

https://www.drupal.org/pift-ci-job/1676236

Hopefully, this patch fixes the D9 test failures. In UiCrudTest, the edit link is tried to be selected using "li.edit", but apparently with the Stark theme element no longer has that class. So I replaced it with li:nth-child(1).

Committed #16