Problem/Motivation

In #3056118: Remove deprecated code from Upgrade Status we found that other than testing code (see #3100308: Make Upgrade Status tests Drupal 9 compatible), there was no other remaining deprecated API but the use of file_directory_temp(). However that requires Drupal 8.8.x and 8.7.x is still supported. We can remove usage of it, if it is not available and still use it if it is. This allows to remove the deprecation notice and still mark it for future removal.

Proposed resolution

Do it.

Remaining tasks

Do it.

User interface changes

None.

API changes

None.

Data model changes

None.

Release notes snippet

None.

CommentFileSizeAuthor
#4 3100361-4.patch899 bytesGábor Hojtsy
#2 3100361-2.patch971 bytesGábor Hojtsy
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Gábor Hojtsy created an issue. See original summary.

Gábor Hojtsy’s picture

Status: Active » Needs review
FileSize
971 bytes
knyshuk.vova’s picture

Status: Needs review » Reviewed & tested by the community
Issue tags: +LutskGCW20

Reviewed. Replacing of old function is correct. Patch can be committed.

Gábor Hojtsy’s picture

Status: Reviewed & tested by the community » Needs review
FileSize
899 bytes

Here is a version with backwards compatibility, so we don't need to up the requirement and still mark it as such and get rid of the deprecation error.

Gábor Hojtsy’s picture

Title: Remove usage of file_directory_temp() once Drupal 8.8.x can be required » Remove usage of file_directory_temp() if its not available
Issue summary: View changes

We can do this now without requiring 8.8.

Gábor Hojtsy’s picture

Version: 8.x-1.x-dev » 8.x-2.x-dev
Gábor Hojtsy’s picture

Title: Remove usage of file_directory_temp() if its not available » Remove usage of file_directory_temp() if its not available for Drupal 9 compatibility
Status: Needs review » Reviewed & tested by the community

  • Gábor Hojtsy committed b7825ad on 8.x-2.x
    Issue #3100361 by Gábor Hojtsy, knyshuk.vova: Remove usage of...
Gábor Hojtsy’s picture

Status: Reviewed & tested by the community » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.