Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
Problem/Motivation
The help page for media library shows a duplicate paragraph. The two versions are the same, except the first has a link in it.
Proposed resolution
Remove the duplicate paragraph.
Remaining tasks
Patch.
User interface changes
None.
API changes
None.
Data model changes
None.
Comments
Comment #2
andrewmacpherson CreditAttribution: andrewmacpherson as a volunteer commentedComment #3
andrewmacpherson CreditAttribution: andrewmacpherson as a volunteer commentedThe problem is where hook_help has some conditional text. First it checks to see if Views UI is enabled, to decide whether to include a link or not. But then it outputs another copy of the paragraph anyway:
Comment #4
panshulk CreditAttribution: panshulk as a volunteer and at Srijan | A Material+ Company for Drupal India Association commentedComment #5
panshulk CreditAttribution: panshulk as a volunteer and at Srijan | A Material+ Company for Drupal India Association commentedHey @andrewmacpherson
Thanks for the patch.
Applied the patch and tested the changes on the Module Help Page.
I am able to see that the help text is non-duplicated and the patch was applied successfully.
Hence moving this to "Reviewed and Tested By Community".
Thanks !
Comment #6
panshulk CreditAttribution: panshulk as a volunteer and at Srijan | A Material+ Company for Drupal India Association commentedComment #7
Kristen Pol@panshulk Forgot to mark it RTBC so doing that based on #5.
Comment #8
xjmThank you for reviewing this issue @panshulk!
The automated testing infrastructure tells us whether the patch applies, so we do not need people to review that or post screenshots of the patch applying. For next time, a screenshot of the user interface before and after would be more helpful.
Comment #13
xjmNormally we wouldn't make string changes in 8.8.x at this point, but it's not actually a string change per se; it's just removing a silly redundant copy of the string. For that reason, I consider this patch-safe.
Committed to 9.1.x through 8.8.x. Thanks!