Problem/Motivation
------ ----------------------------------------------------------------
Line src/Exporter.php
------ ----------------------------------------------------------------
234 Call to deprecated function file_prepare_directory():
in drupal:8.7.0 and is removed from drupal:9.0.0.
Use \Drupal\Core\File\FileSystemInterface::prepareDirectory().
------ ----------------------------------------------------------------
------ -------------------------------------------------------------------------------------------------------------------------------------------------------------
Line tests/src/Kernel/ExporterIntegrationTest.php
------ -------------------------------------------------------------------------------------------------------------------------------------------------------------
21 Usage of deprecated trait Drupal\field\Tests\EntityReference\EntityReferenceTestTrait in class Drupal\Tests\default_content\Kernel\ExporterIntegrationTest:
in drupal:8.6.2 and is removed from drupal:9.0.0. Use
Drupal\Tests\field\Traits\EntityReferenceTestTrait instead.
201 Call to deprecated method setExpectedException() of class Drupal\KernelTests\KernelTestBase:
in drupal:8.8.0 and is removed from drupal:9.0.0.
Backward compatibility for PHPUnit 4 will no longer be supported.
------ -------------------------------------------------------------------------------------------------------------------------------------------------------------
Proposed resolution
Remove deprecated code
Remaining tasks
User interface changes
API changes
Data model changes
Release notes snippet
Comment | File | Size | Author |
---|---|---|---|
#21 | 3098095-21-interdiff.txt | 357 bytes | Berdir |
#21 | 3098095-21.patch | 7.62 KB | Berdir |
| |||
#18 | 3098095-18.patch | 7.63 KB | andypost |
#18 | interdiff.txt | 1.01 KB | andypost |
#10 | interdiff.txt | 1.13 KB | andypost |
Comments
Comment #2
chr.fritschHere is a patch to fix the deprecations
Comment #3
larowlanI think we have to hold off until 8.7 is EOL for some of these?
Comment #4
chr.fritschThis is the only D8.8 deprecation. So since it's only test related, I think we can already commit this.
Comment #5
BerdirFailing tests makes it hard to ensure that everything else still works on 8.7, I'd suggest to combine this with core_version_requirement: ^8.8 || ^9 and wait until @larowlan feels OK with no longer supporting 8.7.
Comment #6
larowlanYeah either that or we have two branches, not fussed - if two branches unblocks people - so be it
Comment #7
BerdirWhether new branch or no, we need the version requirement, so needs work for that.
Comment #8
chr.fritschShould we also remove the drush 8 (not supported with D9) integration here? We already have drush 9+ support
Comment #9
BerdirThere's no need for that, removing drush8 support can be done later when support for D8 is removed entirely, no need to break sites that still use drush8 on D8.
Comment #10
andypostI'd prefer to get commit first #2921377: When Drupal 8.6.0 is released, remove TermEntityNormalizer and tag a new release
So added 8.7.7 requirement to info file and hardened check in for exception message
this method is deprecated in phpunit6 IIRC, so I thing it's good to go
Comment #11
andypostFYI https://phpunit.de/getting-started/phpunit-5.html so since phpunit5
expectException
is recommended methodAssigning to Lee to decide - at least clean-up of test is no longer blocker
is deprecated in 8.7
Comment #12
andypostAlso needs to fix testing modules and schema in test
With #2921377 applied it passes tests on 9.0.x
Comment #13
andypostAnd theme)
Comment #14
andypostand it will need tuning of composer.json
Comment #15
BerdirGoing to need a reroll and updating composer.json too as we already have the drupal/core require there.
Comment #16
andypostComment #17
andypostComment #18
andypostFixed remains
Comment #19
andypostComment #20
andypostComment #21
BerdirI'd say we should remove the version from drupal:hal because it's covered with the line above and it's one thing less we'll need to update in the future.
Comment #23
BerdirThanks, since this only requires 8.7 it's fine to commit now.