grep -nri "deprecated" core/modules/filter/
core/modules/filter//tests/src/Kernel/Migrate/d6/FilterFormatPermissionTest.php:37:   * @expectedDeprecation Passing a migration process plugin as the fourth argument to Drupal\filter\Plugin\migrate\process\d6\FilterFormatPermission::__construct is deprecated in drupal:8.8.0 and will throw an error in drupal:9.0.0. Pass the migrate.lookup service instead. See https://www.drupal.org/node/3047268
core/modules/filter//tests/src/Kernel/FilterLegacyTest.php:23:   * @expectedDeprecation filter_form_access_denied() is deprecated in Drupal 8.8.0 and will be removed before Drupal 9.0.0. Use \Drupal\filter\Element\TextFormat::accessDeniedCallback() instead. See https://www.drupal.org/node/2966725
core/modules/filter//filter.module:310: * @deprecated in drupal:8.8.0 and is removed from drupal:9.0.0. Use
core/modules/filter//filter.module:316:  @trigger_error('filter_form_access_denied() is deprecated in Drupal 8.8.0 and will be removed before Drupal 9.0.0. Use \Drupal\filter\Element\TextFormat::accessDeniedCallback() instead. See https://www.drupal.org/node/2966725', E_USER_DEPRECATED);
core/modules/filter//src/Plugin/migrate/process/d6/FilterFormatPermission.php:29:   * @deprecated in drupal:8.8.x and is removed from drupal:9.0.0. Use
core/modules/filter//src/Plugin/migrate/process/d6/FilterFormatPermission.php:61:      @trigger_error('Passing a migration process plugin as the fourth argument to ' . __METHOD__ . ' is deprecated in drupal:8.8.0 and will throw an error in drupal:9.0.0. Pass the migrate.lookup service instead. See https://www.drupal.org/node/3047268', E_USER_DEPRECATED);
CommentFileSizeAuthor
#8 interdiff.3097751.6-8.txt1.13 KBlongwave
#8 3097751-8.patch8.02 KBlongwave
#6 interdiff.3097751.2-6.txt1.76 KBlongwave
#6 3097751-6.patch7.46 KBlongwave
#2 3097751-2.patch6.06 KBkim.pepper
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

kim.pepper created an issue. See original summary.

kim.pepper’s picture

kim.pepper
Primary language English
Location 🏄‍♂️🇦🇺Sydney, Australia
CreditAttribution: kim.pepper at PreviousNext commented
Status: Active » Needs review
FileSize
3097751-2.patch6.06 KB

This patch:

  • Removes deprecated function from filter.module and test
  • Removes the BC layer from core/modules/filter/src/Plugin/migrate/process/d6/FilterFormatPermission constructor and tests

Status: Needs review » Needs work

The last submitted patch, 2: 3097751-2.patch, failed testing. View results
- codesniffer_fixes.patch Interdiff of automated coding standards fixes only.

andypost’s picture

andypost
he/him
Primary language Russian
CreditAttribution: andypost as a volunteer and at Skilld commented
Related issues: +#3039240: Create a way to declare a plugin as deprecated

this migrations are blocked on #3039240: Create a way to declare a plugin as deprecated

andypost’s picture

andypost
he/him
Primary language Russian
CreditAttribution: andypost as a volunteer and at Skilld commented
Status: Needs work » Postponed
longwave’s picture

longwave
he/him
Primary language English
Location UK
CreditAttribution: longwave as a volunteer commented
Status: Postponed » Needs review
FileSize
3097751-6.patch7.46 KB
interdiff.3097751.2-6.txt1.76 KB

I don't think this needs to be postponed, we are just changing a migration constructor here.

Berdir’s picture

Berdir
Primary language German
Location Switzerland
CreditAttribution: Berdir at MD Systems GmbH commented
Status: Needs review » Needs work

There are a few unused use statements to clean up now, see https://www.drupal.org/pift-ci-job/1563951, clean otherwise.

longwave’s picture

longwave
he/him
Primary language English
Location UK
CreditAttribution: longwave as a volunteer commented
Status: Needs work » Needs review
FileSize
3097751-8.patch8.02 KB
interdiff.3097751.6-8.txt1.13 KB

Thanks for review, cleaned those up.

Berdir’s picture

Berdir
Primary language German
Location Switzerland
CreditAttribution: Berdir at MD Systems GmbH commented
Status: Needs review » Reviewed & tested by the community

Should be good to go then.

  • catch committed 96e280c on 9.0.x 
    Issue #3097751 by longwave, kim.pepper, Berdir: Remove all @deprecated...
catch’s picture

catch
he/him
Primary language English
CreditAttribution: catch at Third and Grove commented
Status: Reviewed & tested by the community » Fixed

Committed 96e280c and pushed to 9.0.x. Thanks!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.