On media_library.widget.es6.js the @file comment states:

@file media_library.widget.js

The same happens for media_library.ui.es6.js.

that should instead refer to the actual file.

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

joey-santiago created an issue. See original summary.

joey-santiago’s picture

joey-santiago’s picture

Title: Wrong @file comment in media_library.widget.es6.js » Wrong @file comment in media_library.widget.es6.js and media_library.ui.es6.js
Issue summary: View changes
FileSize
836 bytes
joey-santiago’s picture

Just a sidenote: i tried running the yarn:build command and everything as stated in the JS in core guide, but the patch hasn't generated anything else... have i missed something?

larowlan’s picture

Status: Active » Needs review

@joey-santiago thanks - i've set the patch to needs review so we get a test run

there is nothing output from the yarn:build process because comments are stripped, so I think we're good.

jibran’s picture

Assigned: joey-santiago » Unassigned
Status: Needs review » Reviewed & tested by the community

Thank you, for the patch the changes look good.

  • larowlan committed dc7f83d on 9.0.x
    Issue #3097242 by joey-santiago: Wrong @file comment in media_library....

  • larowlan committed 21b9dd5 on 8.9.x
    Issue #3097242 by joey-santiago: Wrong @file comment in media_library....
larowlan’s picture

Status: Reviewed & tested by the community » Patch (to be ported)

Committed dc7f83d and pushed to 9.0.x. Thanks!

Backported to 8.9.x

alexpott’s picture

Status: Patch (to be ported) » Fixed

  • alexpott committed 1a0a0a5 on 8.8.x authored by larowlan
    Issue #3097242 by joey-santiago: Wrong @file comment in media_library....

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.