Early Bird Registration for DrupalCon Portland 2024 is open! Register by 23:59 PST on 31 March 2024, to get $100 off your ticket.
On media_library.widget.es6.js the @file comment states:
@file media_library.widget.js
The same happens for media_library.ui.es6.js.
that should instead refer to the actual file.
Comment | File | Size | Author |
---|---|---|---|
#3 | media_library-js-filecomments-3097242-1.patch | 836 bytes | joey-santiago |
#2 | media_library_widget_es6-filecomment-3097242-1.patch | 429 bytes | joey-santiago |
Comments
Comment #2
joey-santiago CreditAttribution: joey-santiago at Trimble Solutions Corporation commentedAnd here's the patch.
Comment #3
joey-santiago CreditAttribution: joey-santiago at Trimble Solutions Corporation commentedComment #4
joey-santiago CreditAttribution: joey-santiago at Trimble Solutions Corporation commentedJust a sidenote: i tried running the
yarn:build
command and everything as stated in the JS in core guide, but the patch hasn't generated anything else... have i missed something?Comment #5
larowlan@joey-santiago thanks - i've set the patch to needs review so we get a test run
there is nothing output from the yarn:build process because comments are stripped, so I think we're good.
Comment #6
jibranThank you, for the patch the changes look good.
Comment #9
larowlanCommitted dc7f83d and pushed to 9.0.x. Thanks!
Backported to 8.9.x
Comment #10
alexpott