Drupal Check reported these issues:

➜  d9 git:(8.8.x) ✗ ./vendor/mglaman/drupal-check/drupal-check --drupal-root=/Applications/MAMP/htdocs/d9 modules/contrib/lightning_core
 81/81 [▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓] 100%

 ------ ----------------------------------------------------------------------------------------------
  Line   modules/acquia_telemetry/tests/src/Kernel/TelemetryTest.php
 ------ ----------------------------------------------------------------------------------------------
  32     Call to deprecated method setExpectedException() of class Drupal\KernelTests\KernelTestBase:
         in drupal:8.8.0 and is removed from drupal:9.0.0.
         Backward compatibility for PHPUnit 4 will no longer be supported.
 ------ ----------------------------------------------------------------------------------------------

 ------ -----------------------------------------------------------------------------
  Line   modules/lightning_search/lightning_search.install
 ------ -----------------------------------------------------------------------------
  19     Call to deprecated function system_rebuild_module_data():
         in drupal:8.8.0 and is removed from drupal:9.0.0.
         Use \Drupal::service('extension.list.module')->getList() instead.
         Note: use reset() only when you really need to rescan and rebuild the list.
 ------ -----------------------------------------------------------------------------

 ------ -----------------------------------------------------------------------------------
  Line   tests/src/Kernel/EntityDescriptionTest.php
 ------ -----------------------------------------------------------------------------------
  66     Call to deprecated method assertInternalType() of class PHPUnit\Framework\Assert:
         https://github.com/sebastianbergmann/phpunit/issues/3369
 ------ -----------------------------------------------------------------------------------

 ------ -----------------------------------------------------------------------------------
  Line   tests/src/Kernel/Update/Update360Test.php
 ------ -----------------------------------------------------------------------------------
  49     Call to deprecated method assertInternalType() of class PHPUnit\Framework\Assert:
         https://github.com/sebastianbergmann/phpunit/issues/3369
  50     Call to deprecated method assertInternalType() of class PHPUnit\Framework\Assert:
         https://github.com/sebastianbergmann/phpunit/issues/3369
 ------ -----------------------------------------------------------------------------------


 [ERROR] Found 5 errors
CommentFileSizeAuthor
#2 deprecated_code_fix_3096212_2.patch2.64 KBpranit84
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

pranit84 created an issue. See original summary.

pranit84’s picture

Patch created to fix the Deprecations.

Earlier for some dependency issue was there:

------ ---------------------------------------------------------------------------
  Line   src/Commands/LightningCoreCommands.php
 ------ ---------------------------------------------------------------------------
         Class Drush\Commands\DrushCommands not found and could not be autoloaded.
 ------ ---------------------------------------------------------------------------

 ------ --------------------------------------------------------------------------------------------------
  Line   tests/contexts/CkEditorContext.behat.inc
 ------ --------------------------------------------------------------------------------------------------
         Class Drupal\DrupalExtension\Context\DrupalSubContextBase not found and could not be autoloaded.
 ------ --------------------------------------------------------------------------------------------------

And fix this, I used the following commands:

composer require drupal/drupal-extension
composer require drush/drush
pranit84’s picture

Status: Active » Needs review
amitgoyal’s picture

Status: Needs review » Reviewed & tested by the community

Thanks @pranit84, looks good to me.

➜  d9 git:(8.8.x) ✗ ./vendor/mglaman/drupal-check/drupal-check --drupal-root=./ modules/contrib/lightning_core

 81/81 [▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓] 100%

 [OK] No errors


➜  d9 git:(8.8.x) ✗ ./vendor/mglaman/drupal-check/drupal-check --drupal-root=./ modules/contrib/lightning_core/modules/lightning_roles

 7/7 [▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓] 100%


 [OK] No errors


➜  d9 git:(8.8.x) ✗ ./vendor/mglaman/drupal-check/drupal-check --drupal-root=./ modules/contrib/lightning_core/modules/lightning_page

 4/4 [▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓] 100%


 [OK] No errors


➜  d9 git:(8.8.x) ✗ ./vendor/mglaman/drupal-check/drupal-check --drupal-root=./ modules/contrib/lightning_core/modules/lightning_contact_form

 2/2 [▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓] 100%


 [OK] No errors


➜  d9 git:(8.8.x) ✗ ./vendor/mglaman/drupal-check/drupal-check --drupal-root=./ modules/contrib/lightning_core/modules/lightning_search

 3/3 [▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓] 100%


 [OK] No errors


➜  d9 git:(8.8.x) ✗ ./vendor/mglaman/drupal-check/drupal-check --drupal-root=./ modules/contrib/lightning_core/modules/acquia_telemetry

 4/4 [▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓] 100%


 [OK] No errors

  • phenaproxima committed c7b86a5 on 8.x-5.x
    Issue #3096212 by pranit84, amitgoyal, phenaproxima: Make Lightning Core...
phenaproxima’s picture

Status: Reviewed & tested by the community » Fixed

Made a few small changes needed to get this to pass on Travis CI, then merged it into the 8.x-5.x branch when it went green. So, all set. Thanks!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.