Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.We need to add the CKEditor in a details box. Due to some specific CSS the editor is nested incorrectly. I attached a screenshot of the issue. The CSS in question is
"#layout-builder-modal details div {
padding: 0 1.5em 1em 1.5em;
}"
I believe it should be
"#layout-builder-modal details > div {
padding: 0 1.5em 1em 1.5em;
}"
I will work on getting a patch out there.
| Comment | File | Size | Author |
|---|---|---|---|
| #6 | layout_builder_modal-fix-ckeditor-in-details-3096039.patch | 1.34 KB | msauber28 |
| |||
| Details CKEditor.png | 63.96 KB | msauber28 | |
Comments
Comment #2
mark_fullmerThanks for reporting this. Can you indicate which version of Drupal core you're testing this against? Changes between Drupal 8.7.x, 8.8.0-alpha1, and 8.8.0-beta1 relating to the Media Library and also CKEditor may account for an introduction of a CSS change; if so, we'd need to ensure that the change also indicates which version(s) of Drupal core it's designed for.
Additionally, ideally, we'd want the patch to replicate the CSS that is provided by Drupal core's "Seven" module, rather than just fixing this observed visual discrepancy.
See https://www.drupal.org/project/drupal/releases/8.8.0-beta1
Comment #3
msauber28 CreditAttribution: msauber28 commentedI'm using 8.7.10. I'm not seeing what CSS you are talking about in the seven module. Do you know where it is?
Comment #4
msauber28 CreditAttribution: msauber28 commentedComment #5
mark_fullmerBased on inline comments in https://git.drupalcode.org/project/layout_builder_modal/blob/8.x-1.x/the..., it looks like what Layout Builder Modal is using is a modification of https://github.com/drupal/drupal/blob/8.8.x/core/themes/seven/css/compon..., since the `.seven-details` class is not present.
So, I think we want to follow suit with Drupal core by adding this: https://github.com/drupal/drupal/blob/8.8.x/core/themes/seven/css/compon... (again, renamed for use outside of the context of Seven.
Comment #6
msauber28 CreditAttribution: msauber28 at Principal Financial Group commentedHere is a patch to fix the issue and it follows the seven theme example
Comment #7
Dave ReidComment #8
mark_fullmerImplementation looks good to me. I'll leave this a RTBC for a day or two for other maintainers to look at, and after that plan to commit it.
Comment #9
msauber28 CreditAttribution: msauber28 commentedIt’s been a couple days. Are we good to commit?
Comment #11
mark_fullmerYes, thanks. Committed & credited! I'll discuss with the other maintainers whether it's time to do a new release.
Comment #12
matt_paz CreditAttribution: matt_paz commentedI just tested this (latest dev) on 8.8.0 and was unable to get it to work. Is is confirmed/expected to work on 8.8.0?Never mind. I just re-tested on bartik w/out lb_modal, and I wasn't able to get CK Editor to load, so I've got something else going on.
Apologies for the misattribution.