FieldTypePluginManager::getPluginClass() should throw an exception when called for a field type that doesn't exist

+++ b/core/tests/Drupal/KernelTests/Core/Field/FieldMissingTypeTest.php
@@ -60,8 +61,8 @@ protected function setUp() {
   public function testFieldStorageMissingType() {
-    $this->expectException(\RuntimeException::class);
-    $this->expectExceptionMessage("Unable to determine class for field type 'foo_field_storage' found in the 'field.storage.entity_test_mulrev.{$this->fieldName}' configuration");
+    $this->expectException(PluginNotFoundException::class);
+    $this->expectExceptionMessage('The "foo_field_storage" plugin does not exist.');

The exception is way way less helpful though. Imo we should preserve the helpful exception somehow. Catching and re-throwing come to mind.

Well we're mapping from storage records so I'm not sure when you'd see the current exception for base fields? I.e. I think it is okay to catch and rethrow in :: mapFromStorageRecords() to improve the exception message.

+1 to updating the exception types to the more meaningful PluginNotFoundException.

+++ b/core/lib/Drupal/Core/Field/FieldTypePluginManager.php
@@ -167,7 +167,7 @@ public function getPreconfiguredOptions($field_type) {
    * {@inheritdoc}
    */
   public function getPluginClass($type) {
-    $plugin_definition = $this->getDefinition($type, FALSE);
+    $plugin_definition = $this->getDefinition($type);
     return $plugin_definition['class'];
   }

Let's update the interface docs with an @throws...
For example:

   * @throws \Drupal\Component\Plugin\Exception\PluginNotFoundException
   *   Thrown if $type is invalid.

I'd also be tempted to make this a one-liner. Ie. return $this->getDefinition($type)['class'];

Thanks @amateescu - this looks good to me. Will leave for someone else to rtbc so I can commit.

There is simply nothing to add.

Committed and pushed a6477d5904 to 9.0.x and d5e903d1bd to 8.9.x. Thanks!

As this is part of the PHP7.4 critical cherry-picked this back to 8.8.x. @catch +1'd the backport.