Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.Problem/Motivation
We should add defaultTheme where it will be required in tests extending BrowserTestBase.
Drupal\Tests\BrowserTestBase::$defaultTheme is required in drupal:9.0.0 when using an install profile that does not set a default theme. See https://www.drupal.org/node/2352949, which includes recommendations on which theme to use.
See https://www.drupal.org/node/3083055
and https://www.drupal.org/project/drupal/issues/3082655
Proposed resolution
Add the defaultTheme property to tests that extend BrowserTestBase, where appropriate or another theme where appropriate, based on https://www.drupal.org/node/3083055
Remaining tasks
User interface changes
API changes
Data model changes
Release notes snippet
| Comment | File | Size | Author |
|---|---|---|---|
| #3 | eck-3095620-3.patch | 1.41 KB | Matroskeen |
| |||
| #2 | 3095620-2.patch | 1.41 KB | rpayanm |
Comments
Comment #2
rpayanmComment #3
MatroskeenThere is some issue with finding title in Stark theme. Let's try with "classy".
Comment #4
MatroskeenSeems fine. I've also created a follow-up issue that noticed during investigating this one: #3107290: Use FunctionalTestBase for all Functional tests
Comment #6
MatroskeenCommitted and pushed to 8.x-1.x.
Thanks!