PHP 7.4 and Drupal 9 testing deprecation [#3094476]

FILE: web/modules/contrib/simple_sitemap/src/Form/SimplesitemapEntitiesForm.php
---------------------------------------------------------------------------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
---------------------------------------------------------------------------------------------------------------------------------------------------------------
118 | WARNING | Passing the $glue and $pieces parameters in reverse order to implode has been deprecated since PHP 7.4; $glue should be the first parameter
| | and $pieces the second
---------------------------------------------------------------------------------------------------------------------------------------------------------------

Comment	File	Size	Author
#3	simplesitemap_php74_testtheme.diff	1.54 KB	sleitner
#3	8.x-3.x: PHP 7.2 & MySQL 5.5, D8.8 29 pass
#2	simplesitemap_php74_testprofile.diff	1.43 KB	sleitner
#2	8.x-3.x: PHP 7.2 & MySQL 5.5, D8.8 3 pass, 2 fail
	simplesitemap_php74.diff	949 bytes	sleitner
	8.x-3.x: PHP 7.2 & MySQL 5.5, D8.8 3 pass, 2 fail

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Comment #1

14 November 2019 at 17:18

sleitner created an issue. See original summary.

Comment #2

sleitner CreditAttribution: sleitner commented 15 November 2019 at 12:33

File	Size
simplesitemap_php74_testprofile.diff	1.43 KB
8.x-3.x: PHP 7.2 & MySQL 5.5, D8.8 3 pass, 2 fail

Drupal\Tests\BrowserTestBase::$defaultTheme is required in drupal:9.0.0 when using an install profile that does not set a default theme. See https://www.drupal.org/node/2352949, which includes recommendations on which theme to use.

Now includes install profile for BrowserTestBase, because tests are failing(Drupal 9 deprecation warning) without profile set

Comment #3

sleitner CreditAttribution: sleitner commented 15 November 2019 at 12:44

File	Size
simplesitemap_php74_testtheme.diff	1.54 KB
8.x-3.x: PHP 7.2 & MySQL 5.5, D8.8 29 pass

Comment #4

sleitner CreditAttribution: sleitner commented 15 November 2019 at 12:49

Status:

Active

» Needs review

Comment #5

sleitner CreditAttribution: sleitner commented 15 November 2019 at 13:40

Title:

PHP 7.4 deprecation

» PHP 7.4 and Drupal 9 testing deprecation

Comment #6

sleitner CreditAttribution: sleitner commented 15 November 2019 at 13:41

Issue tags:

+Drupal 9

Comment #7

15 November 2019 at 18:36

gbyte.co committed a110362 on 8.x-3.x authored by sleitner

Issue #3094476 by sleitner, gbyte.co: PHP 7.4 and Drupal 9 testing...

Comment #8

gbyte CreditAttribution: gbyte as a volunteer and at gbyte commented 15 November 2019 at 18:37

Category:	Bug report	» Task
Status:	Needs review	» Fixed

It's not a bug, but still helpful, thanks.

Comment #9

Kristen Pol

she/her

English

Santa Cruz, CA, USA

CreditAttribution: Kristen Pol at Hook 42 commented 28 November 2019 at 04:55

Issue tags:

-Drupal 9

+Drupal 9 compatibility

Per a Slack discussion with Gábor Hojtsy regarding usage of D9 tags (Drupal 9, Drupal 9 compatibility, Drupal 9 readiness, etc.), "Drupal 9 compatibility" should be used for contributed projects that need updating and "Drupal 9" was the old tag for D8 issues before the D9 branch was ready. Doing tag cleanup here based on that discussion.